Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions cpp/cmake_modules/DefineOptions.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -519,8 +519,8 @@ takes precedence over ccache if a storage backend is configured" ON)
define_option(ARROW_ZSTD_USE_SHARED "Rely on zstd shared libraries where relevant"
${ARROW_DEPENDENCY_USE_SHARED})

define_option(ARROW_USE_GLOG "Build libraries with glog support for pluggable logging"
OFF)
define_option(ARROW_USE_GLOG "Build libraries with glog support for pluggable logging;\
(This is a deprecated option and will be removed in a future release.)" OFF)

define_option(ARROW_WITH_BACKTRACE "Build with backtrace support" ON)

Expand Down Expand Up @@ -703,6 +703,11 @@ macro(config_summary_message)
if(ARROW_PYTHON)
message(WARNING "ARROW_PYTHON is deprecated. Use CMake presets instead.")
endif()

if(ARROW_USE_GLOG)
message(DEPRECATION "ARROW_USE_GLOG is deprecated and will be removed in a future release."
)
endif()
endmacro()

macro(config_summary_json)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,9 @@ arrow::Status RunScenario(arrow::flight::integration_tests::Scenario* scenario)
}

int main(int argc, char** argv) {
ARROW_SUPPRESS_DEPRECATION_WARNING
arrow::util::ArrowLog::InstallFailureSignalHandler();

@pitrou pitrou Nov 17, 2026 •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not keep this and other calls to deprecated APIs, while enclosing them in ARROW_SUPPRESS_DEPRECATION_WARNING ?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean wrap every call of this API in ARROW_SUPPRESS_DEPRECATION_WARNING rather than removing the function entirely? That works, I'll create a commit for it

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we'll just remove the API calls when we actually remove the deprecated APIs.

ARROW_UNSUPPRESS_DEPRECATION_WARNING

gflags::SetUsageMessage("Integration testing client for Flight.");
gflags::ParseCommandLineFlags(&argc, &argv, true);
Expand All @@ -240,6 +242,8 @@ int main(int argc, char** argv) {
}
ABORT_NOT_OK(status);

ARROW_SUPPRESS_DEPRECATION_WARNING
arrow::util::ArrowLog::UninstallSignalAction();
ARROW_UNSUPPRESS_DEPRECATION_WARNING
return 0;
}
2 changes: 2 additions & 0 deletions cpp/src/arrow/flight/sql/example/acero_main.cc
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,9 @@ int main(int argc, char** argv) {

arrow::util::ArrowLog::StartArrowLog("acero-flight-sql-server",
arrow::util::ArrowLogLevel::ARROW_INFO);
ARROW_SUPPRESS_DEPRECATION_WARNING
arrow::util::ArrowLog::InstallFailureSignalHandler();
ARROW_UNSUPPRESS_DEPRECATION_WARNING

arrow::Status st = RunMain(FLAGS_location);

Expand Down
4 changes: 4 additions & 0 deletions cpp/src/arrow/util/logging.cc
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,8 @@ void ArrowLog::StartArrowLog(const std::string& app_name,
#endif
}

ARROW_SUPPRESS_DEPRECATION_WARNING

void ArrowLog::UninstallSignalAction() {
#ifdef ARROW_USE_GLOG
ARROW_LOG(DEBUG) << "Uninstall signal handlers.";
Expand Down Expand Up @@ -223,6 +225,8 @@ void ArrowLog::InstallFailureSignalHandler() {
#endif
}

ARROW_UNSUPPRESS_DEPRECATION_WARNING

bool ArrowLog::IsLevelEnabled(ArrowLogLevel log_level) {
return log_level >= severity_threshold_;
}
Expand Down
4 changes: 4 additions & 0 deletions cpp/src/arrow/util/logging.h
Original file line number Diff line number Diff line change
Expand Up @@ -189,9 +189,13 @@ class ARROW_EXPORT ArrowLog : public ArrowLogBase {

/// Install the failure signal handler to output call stack when crash.
/// If glog is not installed, this function won't do anything.
/// \deprecated Deprecated in 27.0.0. GLog support is deprecated.
ARROW_DEPRECATED("Deprecated in 27.0.0. GLog support is deprecated.")
static void InstallFailureSignalHandler();

/// Uninstall the signal actions installed by InstallFailureSignalHandler.
/// \deprecated Deprecated in 27.0.0. GLog support is deprecated.
ARROW_DEPRECATED("Deprecated in 27.0.0. GLog support is deprecated.")
static void UninstallSignalAction();

/// Return whether or not the log level is enabled in current setting.
Expand Down
2 changes: 1 addition & 1 deletion docs/source/developers/cpp/building.rst
Original file line number Diff line number Diff line change
Expand Up @@ -494,7 +494,7 @@ The build system supports a number of third-party dependencies
* ``BZip2``: for data compression
* ``c-ares``: a dependency of gRPC
* ``gflags``: for command line utilities (formerly Googleflags)
* ``GLOG``: for logging
* ``GLOG``: for logging (deprecated)
* ``google_cloud_cpp_storage``: for Google Cloud Storage support, requires
system cURL and can use the ``BUNDLED`` method described below
* ``gRPC``: for remote procedure calls
Expand Down
Loading