Skip to content

GH-55630: [C++][CI] Append expected prefix on ResolveSimdjsonResult error - #55631

Closed
raulcd wants to merge 2 commits into
apache:mainfrom
raulcd:GH-55630
Closed

raulcd wants to merge 2 commits into
apache:mainfrom
raulcd:GH-55630

Conversation

@raulcd

@raulcd raulcd commented Nov 16, 2026 •

Copy link
Copy Markdown
Member

Rationale for this change

Currently MinGW tests are failing for simdjson. This seems to be related to simdjson 5.2.0 adding the following fix:

It seems an invalid document failed at a different stage on our codebase where we were appending the error prefix but now it fails on simdjson and we are not appending the prefix.

What changes are included in this PR?

Use our JSON parse error: prefix for other logs.

Are these changes tested?

Yes via CI

Are there any user-facing changes?

Yes, users might get a log with a slightly different prefix now but we were missing it in the first place.

Was AI used for this PR?

In accordance to the AI generation guidelines, please disclose below whether and how AI was used in this PR.

PR code and description written by:

  • Human
  • AI

Reviewed before submission by:

  • Human
  • AI
  • Not reviewed

Copilot AI balanced review requested due to automatic review settings November 16, 2026 10:15
@raulcd
raulcd marked this pull request as draft November 16, 2026 10:15
@github-actions

Copy link
Copy Markdown

⚠️ GitHub issue #55630 has been automatically assigned in GitHub to PR creator.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

There are no active review issues for the JSON parser error-prefix changes.

No open issues 🎉

What changed in this PR

This PR standardizes error prefixes in Arrow’s C++ JSON parser, addressing reported MinGW CI failures when newer simdjson versions detect malformed input at a different parsing stage.

Changes:

  • Adds JSON parse error: to object-extraction and object-key-extraction errors while retaining the existing diagnostic details.
File Description
cpp/​src/​arrow/​json/​parser.cc Adds the expected prefix to two simdjson error-conversion messages.

Review effort: Balanced

@raulcd

raulcd commented Nov 16, 2026

Copy link
Copy Markdown
Member Author

@Reranko05 I am not comfortable with this part of the codebase. I am going to close this PR once CI finishes (I just want to validate whether claude's proposed fix solves the issue). This PR was just an investigation, could you maybe take a look at the original CI failures for MinGW and propose proper fixes?

@Reranko05

Copy link
Copy Markdown
Collaborator

@raulcd I will look into this soon and get back to you.

@raulcd

raulcd commented Nov 16, 2026

Copy link
Copy Markdown
Member Author

Closing the PR even though it solves the issues, so someone with better knowledge on the area can assess whether this is the right fix or there is a better one..

@raulcd raulcd closed this Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants