Repository navigation
GH-55628: [C++][Parquet] Stop finalizing column writers after failed writes - #55629
Open
fanruan-tuco wants to merge 1 commit into
Open
fanruan-tuco wants to merge 1 commit into
fanruan-tuco wants to merge 1 commit into
Conversation
…ailed writes Co-Authored-By: Claude Code <noreply@anthropic.com>
fanruan-tuco
requested review from
HuaHuaY,
pitrou and
wgtmac
as code owners
November 16, 2026 08:49
|
Thanks for opening a pull request! This pull request has been automatically converted to a draft because its title doesn't match Arrow's required format. If this is not a minor PR, could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or After updating the title, you can mark the pull request as ready for review. See also: |
fanruan-tuco
marked this pull request as ready for review
November 16, 2026 08:55
Author
|
|
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A failed dictionary-encoded write (e.g. OOM while growing the dictionary hash table) can leave the encoder pointing at freed memory. The writer destructor still calls
Close(), which writes the dictionary page and crashes with SIGSEGV instead of surfacing the error.Fixes #55628.
Changes
failed_flag inColumnWriterImpl, set aroundWriteBatch,WriteBatchSpaced, andWriteArrowfor both exceptions and non-OKStatusreturns.Close()and any further writes are rejected once a write has failed.Tests
13 new regression cases inject OOM via
ProxyMemoryPool, covering all three write entry points, explicit close vs. destruction, memory recovery, and non-OKStatusreturns. The column writer suite passes (316 tests).Critical Fix: this fixes a crash (SIGSEGV) caused by use-after-free during writer destruction.
Was AI used for this PR?
🤖 Generated with Claude Code