Repository navigation
Conversation
thisisnic
requested review from
assignUser,
jonkeane,
kou and
raulcd
as code owners
November 15, 2026 23:28
Member
Author
|
@github-actions crossbow submit test-r-m1-san |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the temporary gettext workaround in the macOS arm64 sanitizer job.
No open issues 🎉
What changed in this PR
Adds a temporary CI workaround for GH-55625 so the macOS arm64 R-devel sanitizer job has libintl.h available when pak rebuilds Matrix from source.
Changes:
- Installs CRAN’s gettext build before the dependency installation step.
- Adds a TODO to remove the workaround once r-lib/pak#926 is resolved.
| File | Description |
|---|---|
dev/tasks/r/github.macos.m1san.yml |
Adds the gettext installation step and documents its removal condition. |
Review effort: Balanced
|
Revision: 1396562 Submitted crossbow builds: ursacomputing/crossbow @ actions-c8234434eb
|
Member
Author
|
The dev version of pak now fixes this, we should ditch this PR and just use that instead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The nightly
test-r-m1-sanjob fails because pak 0.11.2 rebuildsMatrixfrom source on R-devel macOS arm64 (r-lib/pak#926), and the build needslibintl.h.What changes are included in this PR?
Install CRAN's gettext build before the "Install dependencies" step, with a TODO to remove it once the pak issue is resolved.
Are these changes tested?
Via a crossbow run of
test-r-m1-sanon this PR.Are there any user-facing changes?
No.
Was AI used for this PR?
Used AI for just about everything except this sentence but gave it a look over and added the TODO to remove this fix when pak updates upstream.
PR code and description written by:
Reviewed before submission by: