Repository navigation
GH-55616: [C++][Compute] Support decimal and fixed_size_binary types in search_sorted - #55617
Open
SohamDutta02 wants to merge 1 commit into
Open
SohamDutta02 wants to merge 1 commit into
SohamDutta02 wants to merge 1 commit into
Conversation
…sorted search_sorted raised NotImplemented for decimal32/64/128/256 and fixed_size_binary inputs, although these types are orderable and already supported by sort_indices. Add them to the type dispatch. The search itself needs no changes since GetViewType and CompareTypeValues already handle them; only the two type_singleton() calls, which don't exist for parametric types, are adjusted.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
search_sortedraisedNotImplementedfor decimal32/64/128/256 andfixed_size_binaryinputs, even though these types are orderable and supported bysort_indices.What changes are included in this PR?
FixedSizeBinaryTypeandDecimal32/64/128/256Typeto thesearch_sortedtype dispatch. The binary search itself is unchanged:GetViewTypeandCompareTypeValuesalready handle these types.TypeTraits<T>::type_singleton(), which only exists for parameter-free types, inVisitArrayNeedleRunsandComputeInsertionIndices. Parametric needles already have the values' exact type, so they are used as-is.Are these changes tested?
Yes. Smoke cases for the five new types were added to the parametrized array/scalar tests (the decimal cases include negative values), plus a run-end encoded decimal test with a leading null and a null needle.
arrow-compute-vector-search-sorted-testpasses locally.Are there any user-facing changes?
Yes:
search_sortednow accepts decimal andfixed_size_binaryinputs.Was AI used for this PR?
Yes. The tests and description were AI-assisted; I reviewed the diff and the test results before submitting.
PR code and description written by:
Reviewed before submission by: