Skip to content

GH-55598: [C++][Parquet] Align Parquet-to-GeoArrow conversions with Parquet, GeoParquet, and arrow-rs - #55599

Merged
pitrou merged 6 commits into
apache:mainfrom
paleolimbot:codex/geoarrow-conversion
Nov 18, 2026
Merged

pitrou merged 6 commits into
apache:mainfrom
paleolimbot:codex/geoarrow-conversion

Conversation

@paleolimbot

@paleolimbot paleolimbot commented Nov 13, 2026 •

Copy link
Copy Markdown
Member

Rationale for this change

GeoArrow input to the Parquet reader with a "missing" CRS (null in GeoParquet, None in GeoPandas) are currently written with a Parquet CRS that denotes lon/lat and will roundtrip incorrectly when read back to GeoPandas/GeoArrow.

What changes are included in this PR?

Adds a mapping between srid:0 and GeoArrow's "missing" CRS to match arrow-rs, GeoParquet, and the discussion around srid:0 in the Parquet format PR adding it as an example.

Are these changes tested?

Yes, the parameterized geospatial logical type mapping tests in both directions were ported from arrow-rs and include srid:0.

Are there any user-facing changes?

Yes: under a very specific set of circumstances (GeoArrow extension types registered, Parquet

Was AI used for this PR?

In accordance to the AI generation guidelines, please disclose below whether and how AI was used in this PR.

PR code and description written by:

  • Human
  • AI

Reviewed before submission by:

  • Human
  • AI
  • Not reviewed

Closes #55598.

@github-actions

Copy link
Copy Markdown

Thanks for opening a pull request!

This pull request has been automatically converted to a draft because its title doesn't match Arrow's required format.

If this is not a minor PR, could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

After updating the title, you can mark the pull request as ready for review.

See also:

@paleolimbot paleolimbot changed the title [C++][Parquet]: Align Parquet-to-GeoArrow conversions with Parquet, GeoParquet, and arrow-rs GH-55598: [C++][Parquet] Align Parquet-to-GeoArrow conversions with Parquet, GeoParquet, and arrow-rs Nov 13, 2026
@github-actions

Copy link
Copy Markdown

⚠️ GitHub issue #55598 has been automatically assigned in GitHub to PR creator.

@paleolimbot
paleolimbot marked this pull request as ready for review November 13, 2026 18:26
@paleolimbot

Copy link
Copy Markdown
Member Author

cc @wgtmac and @jorisvandenbossche

@wgtmac wgtmac left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @paleolimbot!

@pitrou

pitrou commented Nov 17, 2026

Copy link
Copy Markdown
Member

@github-actions crossbow submit -g cpp

@github-actions

Copy link
Copy Markdown

Revision: 8948f00

Submitted crossbow builds: ursacomputing/crossbow @ actions-919d56f824

Task Status
example-cpp-minimal-build-static GitHub Actions
example-cpp-minimal-build-static-system-dependency GitHub Actions
example-cpp-tutorial GitHub Actions
test-build-cpp-fuzz GitHub Actions
test-conda-cpp GitHub Actions
test-conda-cpp-valgrind GitHub Actions
test-debian-13-cpp-amd64 GitHub Actions
test-debian-13-cpp-i386 GitHub Actions
test-debian-experimental-cpp-gcc-15 GitHub Actions
test-fedora-42-cpp GitHub Actions
test-ubuntu-22.04-cpp GitHub Actions
test-ubuntu-22.04-cpp-bundled GitHub Actions
test-ubuntu-22.04-cpp-emscripten GitHub Actions
test-ubuntu-22.04-cpp-no-threading GitHub Actions
test-ubuntu-24.04-cpp GitHub Actions
test-ubuntu-24.04-cpp-gcc-13-bundled GitHub Actions
test-ubuntu-24.04-cpp-gcc-14 GitHub Actions
test-ubuntu-24.04-cpp-minimal-with-formats GitHub Actions
test-ubuntu-24.04-cpp-thread-sanitizer GitHub Actions

@paleolimbot

Copy link
Copy Markdown
Member Author

@github-actions crossbow submit -g cpp

@github-actions

Copy link
Copy Markdown

Revision: 2ed428f

Submitted crossbow builds: ursacomputing/crossbow @ actions-e2747b8627

Task Status
example-cpp-minimal-build-static GitHub Actions
example-cpp-minimal-build-static-system-dependency GitHub Actions
example-cpp-tutorial GitHub Actions
test-build-cpp-fuzz GitHub Actions
test-conda-cpp GitHub Actions
test-conda-cpp-valgrind GitHub Actions
test-debian-13-cpp-amd64 GitHub Actions
test-debian-13-cpp-i386 GitHub Actions
test-debian-experimental-cpp-gcc-15 GitHub Actions
test-fedora-42-cpp GitHub Actions
test-ubuntu-22.04-cpp GitHub Actions
test-ubuntu-22.04-cpp-bundled GitHub Actions
test-ubuntu-22.04-cpp-emscripten GitHub Actions
test-ubuntu-22.04-cpp-no-threading GitHub Actions
test-ubuntu-24.04-cpp GitHub Actions
test-ubuntu-24.04-cpp-gcc-13-bundled GitHub Actions
test-ubuntu-24.04-cpp-gcc-14 GitHub Actions
test-ubuntu-24.04-cpp-minimal-with-formats GitHub Actions
test-ubuntu-24.04-cpp-thread-sanitizer GitHub Actions

@pitrou pitrou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @paleolimbot !

@pitrou
pitrou merged commit dd7dfc6 into apache:main Nov 18, 2026
52 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[C++][Parquet] Align Parquet geometry/geography CRS handling with arrow-rs and Parquet spec

3 participants