Repository navigation
GH-55587: Install Node 24 for latest Azurite on Ubuntu 24.04 dockerfile - #55589
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the Ubuntu 24.04 C++ CI image update that installs Node.js 22 before Azurite.
No open issues 🎉
What changed in this PR
Updates the Ubuntu 24.04 C++ CI image to install Node.js 22 before Azurite, addressing Azurite startup failures in the ASAN/UBSAN sanitizer job.
Changes:
- Installs Node.js 22 using
npx --yes n 22. - Adds a comment explaining the version requirement and Ubuntu 24.04’s older default.
| File | Description |
|---|---|
ci/docker/ubuntu-24.04-cpp.dockerfile |
Installs Node.js 22 before Azurite to support its runtime requirements. |
Review effort: Balanced
|
The C++ / AMD64 Ubuntu 24.04 C++ ASAN UBSAN (pull_request) is now successful |
|
@github-actions crossbow submit test-ubuntu-24.04-cpp-gcc-14 |
|
Revision: da559b3 Submitted crossbow builds: ursacomputing/crossbow @ actions-70842dd18c
|
kou
left a comment
There was a problem hiding this comment.
+1
We may want to use Node.js 24 not 22 because Node.js will reach EOL on 2027-04-30.
|
@github-actions crossbow submit test-ubuntu-24.04-cpp-gcc-14 |
|
Revision: 3f993e1 Submitted crossbow builds: ursacomputing/crossbow @ actions-e5d2f528fd
|
|
@github-actions crossbow submit test-ubuntu-24.04-cpp test-ubuntu-24.04-cpp-thread-sanitizer |
|
Revision: 3f993e1 Submitted crossbow builds: ursacomputing/crossbow @ actions-279e6f563b
|
Rationale for this change
Currently the C++ / AMD64 Ubuntu 24.04 C++ ASAN UBSAN is failing.
What changes are included in this PR?
Install node 24 so azurite starts even though 22 is enough it will be EOL soon-ish.
Are these changes tested?
Yes, I've validated locally via:
And is tested on CI
Are there any user-facing changes?
No
Was AI used for this PR?
In accordance to the AI generation guidelines, please disclose below whether and how AI was used in this PR.
PR code and description written by:
AI was used for log analysis and possible solutions.
Reviewed before submission by: