Repository navigation
GH-55486: [Python] Make test_asarray run and update it to the current Scalar API - #55585
Open
AFOliveira wants to merge 1 commit into
Open
AFOliveira wants to merge 1 commit into
AFOliveira wants to merge 1 commit into
Conversation
…urrent Scalar API test_asarray is marked both pandas and nopandas. Exactly one of those groups is enabled in any run, so the test is always skipped. Its body has gone stale meanwhile: it uses the removed Int64Value alias and compares Scalars with Python ints. Replace the two marks with the numpy mark, so the test runs with and without pandas, and update the body to the current Scalar API. Checked on x86-64 against the 26.0.1 wheel: the old body fails at the tolist() assertion, the new test passes.
|
|
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
test_asarrayis marked bothpandasandnopandas. Exactly one of those groups is enabled in any run, so the test is always skipped. Its body has gone stale meanwhile: it uses the removedInt64Valuealias and compares Scalars with Python ints.What changes are included in this PR?
@pytest.mark.numpy, so the test runs with and without pandas.as_py(),pa.Int64Scalar).Are these changes tested?
The change is to a test. On x86-64 against the 26.0.1 wheel, the old body fails at the
tolist()assertion and the new test passes. Not run against a build ofmain.#55264 touches the same lines of this test.
Are there any user-facing changes?
No.
Was AI used for this PR?
PR code and description written by:
Reviewed before submission by: