Skip to content

GH-55473: [Dev] Add boring-cyborg app configuration and remove dev_pr.yml workflow - #55474

Merged
raulcd merged 1 commit into
apache:mainfrom
raulcd:GH-55392
Nov 18, 2026
Merged

raulcd merged 1 commit into
apache:mainfrom
raulcd:GH-55392

Conversation

@raulcd

@raulcd raulcd commented Nov 10, 2026 •

Copy link
Copy Markdown
Member

Rationale for this change

GitHub is going to block the pull_request_target event from the 2nd of December:

What changes are included in this PR?

Remove the dev_pr.yml workflow and change it with configration for boring-cyborg app.

Are these changes tested?

Yes, as seen on the PR comments I've added the app in my fork and have tested the app config.

Are there any user-facing changes?

Not for users.

For devs, issues are not auto-assigned anymore.
Automatic draft conversion when bad PR title and automated message with explanation of wrong PR titles won't appear anymore but there's a new CI check that will fail.

Was AI used for this PR?

In accordance to the AI generation guidelines, please disclose below whether and how AI was used in this PR.

PR code and description written by:

  • Human
  • AI

Reviewed before submission by:

  • Human
  • AI
  • Not reviewed

@github-actions

Copy link
Copy Markdown

⚠️ GitHub issue #55392 has been automatically assigned in GitHub to PR creator.

@raulcd

raulcd commented Nov 10, 2026

Copy link
Copy Markdown
Member Author

@kou @pitrou I've been exploring removing the dev_pr.yml workflow with the cyborg-app.
The biggest thing we lose is the auto-assign of issues. We could have a check to validate the issue is assigned but as users can't assign the issue themselves (unless they have triage) and we removed the ability to use take this would just give us more maintenance to maintainers.
We could at merge time (on the merge script) assign the issue to the PR author and if it fails (user never commented on issue) we can just ignore the assignation as the important bit is the Author of the PR and this is what we count as contribution credit.
What are your thoughts?

I can also split this PR into multiple PRs and only move the labeler first and then the title check, issue link so it's easier to review.

@pitrou

pitrou commented Nov 10, 2026

Copy link
Copy Markdown
Member

Can we see what boring-cyborg looks like on an actual PR?

@raulcd

raulcd commented Nov 10, 2026

Copy link
Copy Markdown
Member Author

Can we see what boring-cyborg looks like on an actual PR?

This PR on arrow-rs shows how the label was added by the cyborg-app:

As per testing all the functionality on our repo, unfortunately we can't until this is merged on main.

I can change this to only replace the labeler and we can validate the rest of the functionality one feature at a time or I could try installing the app on my fork to show it.

@Reranko05

Copy link
Copy Markdown
Collaborator

@raulcd With Boring-Cyborg, which workflows will run for first-time contributors before a maintainer approves their workflow runs?

(I think the AI disclosure check(#55361) should run before approval so that we can close PRs that fail the disclosure policy without requiring maintainers to approve their workflows first.)

@raulcd

raulcd commented Nov 10, 2026

Copy link
Copy Markdown
Member Author

@raulcd With Boring-Cyborg, which workflows will run for first-time contributors before a maintainer approves their workflow runs?

To be honest, I don't know how can I check that.

@pitrou

pitrou commented Nov 10, 2026

Copy link
Copy Markdown
Member

Ok, a question: if someone manually adds or removes a label, does boring-cyborg attempt to undo the change?

@pitrou

pitrou commented Nov 10, 2026

Copy link
Copy Markdown
Member

Also, at some point it would be nice if there was a system to automatically correct the PR title to include the selected components.

@kou kou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Let's try boring-cyborg. If we have missing features, we can improve boring-cyborg because boring-cyborg is an OSS.

@raulcd

raulcd commented Nov 11, 2026

Copy link
Copy Markdown
Member Author

I've merged this on my fork and have created a couple issues and a couple of PRs to test.
@pitrou the main finding is, boring-cyborg only adds labels it does not remove them.

  • PR 1 (GH-103: [CI] Boring Cyborg test A raulcd/arrow#104)
    • I created a PR pointing to an issue (102) the cyborg bot updated the link to the issue.
    • I updated the PR with a different title pointing to a different issue (103) the cyborg bot updated the description with the new link.
    • I've added manually a label. Cyborg did not remove it.
    • I've updated with a new commit that changes other files the cyborg bot did not remove the labels
    • I've updated with a new commit that changes other files and should add a new label. The new label is updated, old labels are not removed.
  • PR 2 (Fix stuff raulcd/arrow#105)
    • I created a PR with a wrong title. The cyborg bot fails the PR with the following CI job failure (PR Title — Title must start with 'GH-: [Component]' or 'MINOR: [Component]')
  • PR 3 (MINOR: [Docs] Boring Cyborg test C raulcd/arrow#106)
    • MINOR PR no link updated, CI for the title check successful, labels updated.
  • PR 4 (GH-102: [R] Boring Cyborg test D raulcd/arrow#107):
    • The description does not contain the placeholder for the issue link. The bot doesn't update it or add it. labels and title check works as expected.

@raulcd
raulcd marked this pull request as ready for review November 11, 2026 10:51
Copilot AI balanced review requested due to automatic review settings November 11, 2026 10:51

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the migration of PR housekeeping to Boring Cyborg.

No open issues 🎉

What changed in this PR

Migrates PR housekeeping from the dev_pr.yml workflow to the Boring Cyborg GitHub App, addressing part of GH-55392’s removal of pull_request_target workflows.

Changes:

  • Configures component labeling, PR title validation, and issue links through Boring Cyborg.
  • Removes the old workflow and supporting scripts, including automatic issue assignment and draft conversion.
  • Updates the PR template and CI documentation for the app-based setup.
File Description
docs/​source/​developers/​continuous_integration/​overview.rst Documents app-based PR housekeeping.
.github/​workflows/​dev_pr/​title_check.md Removes the invalid-title comment template.
.github/​workflows/​dev_pr/​title_check.js Removes title checking and automatic draft conversion.
.github/​workflows/​dev_pr/​link.js Removes scripted issue-link insertion.
.github/​workflows/​dev_pr/​labeler.yml Removes the old component-label configuration.
.github/​workflows/​dev_pr/​issue_check.js Removes issue checks and automatic assignment.
.github/​workflows/​dev_pr/​helpers.js Removes helpers used by the deleted scripts.
.github/​workflows/​dev_pr.yml Removes the PR housekeeping workflow.
.github/​pull_request_template.md Adds a placeholder for automatic issue links.
.github/​boring-cyborg.yml Configures labels, title validation, and issue-link insertion.

Review effort: Balanced

@raulcd

raulcd commented Nov 11, 2026

Copy link
Copy Markdown
Member Author

@Jefffrey FYI

@raulcd
raulcd requested review from pitrou, rok and thisisnic November 11, 2026 10:58
@raulcd

raulcd commented Nov 11, 2026

Copy link
Copy Markdown
Member Author

@Reranko05 I've read a little more about this. boring-cyborg app is an app that runs always without workflow approval (labels/issue link/title check). Any pull_request workflow would still require approval for first time contributors, the only ones that did not require approval were pull_request_target and those are being removed by GitHub.
We could potentially just have a scheduled job that runs every X amount of time that scans new PRs and "forces" the AI disclosure, we can also configure boring-cyborg to add a message specifically stating new contributors to review the AI guidelines with their firstPRWelcomeComment:. This won't enforce though.

@raulcd

raulcd commented Nov 11, 2026

Copy link
Copy Markdown
Member Author

As a summary the biggest gap with the new set up is that issues are not auto-assigned anymore, we can potentially automate this either via the merge script or if the merge script goes away via some automation once a new commit lands in main.

@raulcd raulcd changed the title GH-55392: [Dev] Add boring-cyborg app configuration and remove dev_pr.yml workflow GH-55473: [Dev] Add boring-cyborg app configuration and remove dev_pr.yml workflow Nov 11, 2026
@rok

rok commented Nov 12, 2026

Copy link
Copy Markdown
Member

See f37b26b for how we could post-merge auto assign with gh scripts.

@Reranko05

Copy link
Copy Markdown
Collaborator

@raulcd Thanks for looking into it. A scheduled workflow sounds like a reasonable compromise. firstPRWelcomeComment would be useful for informing newcomers about the AI guidelines, but as you said we can't rely on it for enforcement. We can discuss the implementation details in the AI disclosure issue #55358 once this PR is merged.

@raulcd

raulcd commented Nov 16, 2026

Copy link
Copy Markdown
Member Author

Are there any concerns on moving forward with this?

@rok

rok commented Nov 16, 2026

Copy link
Copy Markdown
Member

No concerns. Looking forward to rebase #55484 onto this.

@raulcd

raulcd commented Nov 17, 2026

Copy link
Copy Markdown
Member Author

@pitrou @AlenkaF @thisisnic @kou @tadeja I plan to merge this in ~24 hours if no concerns are raised. I'll work with Rok on trying to automate assigning the issue on merge afterwards via merge script or if we remove the merge script via a workflow on commit to main.

@pitrou

pitrou commented Nov 17, 2026

Copy link
Copy Markdown
Member

I've merged this on my fork and have created a couple issues and a couple of PRs to test.
@pitrou the main finding is, boring-cyborg only adds labels it does not remove them.

That's great, thank you!

@AlenkaF AlenkaF left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @raulcd !

@raulcd
raulcd merged commit eb9c885 into apache:main Nov 18, 2026
35 checks passed
@raulcd
raulcd deleted the GH-55392 branch November 18, 2026 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants