Repository navigation
GH-55473: [Dev] Add boring-cyborg app configuration and remove dev_pr.yml workflow - #55474
Conversation
…dev_pr.yml workflow
|
|
|
@kou @pitrou I've been exploring removing the I can also split this PR into multiple PRs and only move the labeler first and then the title check, issue link so it's easier to review. |
|
Can we see what boring-cyborg looks like on an actual PR? |
This PR on arrow-rs shows how the label was added by the cyborg-app: As per testing all the functionality on our repo, unfortunately we can't until this is merged on main. I can change this to only replace the labeler and we can validate the rest of the functionality one feature at a time or I could try installing the app on my fork to show it. |
|
@raulcd With Boring-Cyborg, which workflows will run for first-time contributors before a maintainer approves their workflow runs? (I think the AI disclosure check(#55361) should run before approval so that we can close PRs that fail the disclosure policy without requiring maintainers to approve their workflows first.) |
To be honest, I don't know how can I check that. |
|
Ok, a question: if someone manually adds or removes a label, does boring-cyborg attempt to undo the change? |
|
Also, at some point it would be nice if there was a system to automatically correct the PR title to include the selected components. |
kou
left a comment
There was a problem hiding this comment.
+1
Let's try boring-cyborg. If we have missing features, we can improve boring-cyborg because boring-cyborg is an OSS.
|
I've merged this on my fork and have created a couple issues and a couple of PRs to test.
|
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the migration of PR housekeeping to Boring Cyborg.
No open issues 🎉
What changed in this PR
Migrates PR housekeeping from the dev_pr.yml workflow to the Boring Cyborg GitHub App, addressing part of GH-55392’s removal of pull_request_target workflows.
Changes:
- Configures component labeling, PR title validation, and issue links through Boring Cyborg.
- Removes the old workflow and supporting scripts, including automatic issue assignment and draft conversion.
- Updates the PR template and CI documentation for the app-based setup.
| File | Description |
|---|---|
docs/source/developers/continuous_integration/overview.rst |
Documents app-based PR housekeeping. |
.github/workflows/dev_pr/title_check.md |
Removes the invalid-title comment template. |
.github/workflows/dev_pr/title_check.js |
Removes title checking and automatic draft conversion. |
.github/workflows/dev_pr/link.js |
Removes scripted issue-link insertion. |
.github/workflows/dev_pr/labeler.yml |
Removes the old component-label configuration. |
.github/workflows/dev_pr/issue_check.js |
Removes issue checks and automatic assignment. |
.github/workflows/dev_pr/helpers.js |
Removes helpers used by the deleted scripts. |
.github/workflows/dev_pr.yml |
Removes the PR housekeeping workflow. |
.github/pull_request_template.md |
Adds a placeholder for automatic issue links. |
.github/boring-cyborg.yml |
Configures labels, title validation, and issue-link insertion. |
Review effort: Balanced
|
@Jefffrey FYI |
|
@Reranko05 I've read a little more about this. boring-cyborg app is an app that runs always without workflow approval (labels/issue link/title check). Any pull_request workflow would still require approval for first time contributors, the only ones that did not require approval were pull_request_target and those are being removed by GitHub. |
|
As a summary the biggest gap with the new set up is that issues are not auto-assigned anymore, we can potentially automate this either via the merge script or if the merge script goes away via some automation once a new commit lands in main. |
|
See f37b26b for how we could post-merge auto assign with |
|
@raulcd Thanks for looking into it. A scheduled workflow sounds like a reasonable compromise. |
|
Are there any concerns on moving forward with this? |
|
No concerns. Looking forward to rebase #55484 onto this. |
|
@pitrou @AlenkaF @thisisnic @kou @tadeja I plan to merge this in ~24 hours if no concerns are raised. I'll work with Rok on trying to automate assigning the issue on merge afterwards via merge script or if we remove the merge script via a workflow on commit to main. |
That's great, thank you! |
Rationale for this change
GitHub is going to block the pull_request_target event from the 2nd of December:
What changes are included in this PR?
Remove the
dev_pr.ymlworkflow and change it with configration for boring-cyborg app.Are these changes tested?
Yes, as seen on the PR comments I've added the app in my fork and have tested the app config.
Are there any user-facing changes?
Not for users.
For devs, issues are not auto-assigned anymore.
Automatic draft conversion when bad PR title and automated message with explanation of wrong PR titles won't appear anymore but there's a new CI check that will fail.
Was AI used for this PR?
In accordance to the AI generation guidelines, please disclose below whether and how AI was used in this PR.
PR code and description written by:
Reviewed before submission by: