Repository navigation
GH-51694: [C++][CI][Packaging][FlightPRC][ODBC] Upload macOS DYLIB and PKG to GitHub release #55321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alinaliBQ
wants to merge
1
commit into
apache:main
Choose a base branch
from
dremio:gh-49411-macos-ci-upload
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+345
−54
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,94 @@ | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
|
|
||
| name: ODBC macOS Reusable | ||
| description: Install dependencies and build the Flight SQL ODBC driver on macOS | ||
| inputs: | ||
| architecture: | ||
| description: 'Architecture to build for (AMD64 or ARM64)' | ||
| required: true | ||
| generate-installer: | ||
| description: 'Whether to run cpack to generate the .pkg installer after the build' | ||
| required: false | ||
| default: 'false' | ||
| runs: | ||
| using: "composite" | ||
| steps: | ||
| - name: Install Dependencies | ||
| shell: bash | ||
| run: | | ||
| brew bundle --file=cpp/Brewfile | ||
|
|
||
| # We want to use bundled RE2 for static linking. If | ||
| # Homebrew's RE2 is installed, its header file may be used. | ||
| # We uninstall Homebrew's RE2 to ensure using bundled RE2. | ||
| brew uninstall grpc || : # gRPC depends on RE2 | ||
| brew uninstall grpc@1.54 || : # gRPC 1.54 may be installed too | ||
| brew uninstall re2 | ||
|
|
||
| # We want to use bundled Protobuf for static linking. If | ||
| # Homebrew's Protobuf is installed, its library file may be | ||
| # used on test. We uninstall Homebrew's Protobuf to ensure using | ||
| # bundled Protobuf. | ||
| brew uninstall protobuf | ||
|
|
||
| # We want to use bundled Boost for static linking. | ||
| brew uninstall boost | ||
| - name: Setup ccache | ||
| shell: bash | ||
| run: | | ||
| ci/scripts/ccache_setup.sh | ||
| - name: ccache info | ||
| id: ccache-info | ||
| shell: bash | ||
| run: | | ||
| echo "cache-dir=$(ccache --get-config cache_dir)" >> $GITHUB_OUTPUT | ||
| - name: Restore ccache | ||
| uses: apache/infrastructure-actions/stash/restore@5a4eaabe6c43770c9df95875a513a6b8362be5eb | ||
| with: | ||
| path: ${{ steps.ccache-info.outputs.cache-dir }} | ||
| key: cpp-odbc-ccache-macos-${{ inputs.architecture }}-${{ env.ARROW_BUILD_TYPE }} | ||
| - name: Build | ||
| shell: bash | ||
| run: | | ||
| # Homebrew uses /usr/local as prefix. So packages | ||
| # installed by Homebrew also use /usr/local/include. We | ||
| # want to include headers for packages installed by | ||
| # Homebrew as system headers to ignore warnings in them. | ||
| # But "-isystem /usr/local/include" isn't used by CMake | ||
| # because /usr/local/include is marked as the default | ||
| # include path. So we disable -Werror to avoid build error | ||
| # by warnings from packages installed by Homebrew. | ||
| export BUILD_WARNING_LEVEL=PRODUCTION | ||
| LIBIODBC_DIR="$(brew --cellar libiodbc)/$(brew list --versions libiodbc | awk '{print $2}')" | ||
| ODBC_INCLUDE_DIR=$LIBIODBC_DIR/include | ||
| export ARROW_CMAKE_ARGS="-DODBC_INCLUDE_DIR=$ODBC_INCLUDE_DIR" | ||
| export CXXFLAGS="$CXXFLAGS -I$ODBC_INCLUDE_DIR" | ||
| ci/scripts/cpp_build.sh $(pwd) $(pwd)/build | ||
| - name: Save ccache | ||
| if: ${{ !cancelled() }} | ||
| continue-on-error: true | ||
| uses: apache/infrastructure-actions/stash/save@5a4eaabe6c43770c9df95875a513a6b8362be5eb | ||
| with: | ||
| path: ${{ steps.ccache-info.outputs.cache-dir }} | ||
| key: cpp-odbc-ccache-macos-${{ inputs.architecture }}-${{ env.ARROW_BUILD_TYPE }} | ||
| - name: Generate macOS Installer | ||
| if: inputs.generate-installer == 'true' | ||
| shell: bash | ||
| run: | | ||
| cd build/cpp | ||
| cpack |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add this file to Dependabot targets?