Repository navigation
GH-55258: [C++] Move Azure and its SDK to its own libarrow_azure.so #55299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
raulcd
wants to merge
9
commits into
apache:main
Choose a base branch
from
raulcd:GH-55258
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+525
−52
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
eb78bf2
GH-55258: [C++] Move Azure to Filesystem Registry
raulcd 6238191
Initial move of Azure to its own module
raulcd 9bc9f3e
Add bindings for python and R
raulcd 7f28815
Add azure module test
raulcd 053abc2
Add Linux packaging split for azure
raulcd 417c470
Some more changes to docs, meson build and validations
raulcd 0dfcc22
Add ARROW_EXAMPLE_AZURE_STATIC_CHECK test
raulcd 2560293
Add missing PC flags
raulcd 79a44fd
Move Azure and its dependencies to ARROW_AZURE_BUNDLED_STATIC_LIBS
raulcd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,76 @@ | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
| # | ||
| # This config sets the following variables in your project:: | ||
| # | ||
| # ArrowAzure_FOUND - true if Arrow Azure found on the system | ||
| # | ||
| # This config sets the following targets in your project:: | ||
| # | ||
| # ArrowAzure::arrow_azure_shared - for linked as shared library if shared library is built | ||
| # ArrowAzure::arrow_azure_static - for linked as static library if static library is built | ||
|
|
||
| @PACKAGE_INIT@ | ||
|
|
||
| set(ARROW_AZURE_SYSTEM_DEPENDENCIES "@ARROW_AZURE_SYSTEM_DEPENDENCIES@") | ||
| set(ARROW_AZURE_BUNDLED_STATIC_LIBS "@ARROW_AZURE_BUNDLED_STATIC_LIBS@") | ||
|
|
||
| include(CMakeFindDependencyMacro) | ||
| find_dependency(Arrow CONFIG) | ||
|
|
||
| if(ARROW_BUILD_STATIC) | ||
| arrow_find_dependencies("${ARROW_AZURE_SYSTEM_DEPENDENCIES}") | ||
| endif() | ||
|
|
||
| include("${CMAKE_CURRENT_LIST_DIR}/ArrowAzureTargets.cmake") | ||
|
|
||
| if(TARGET ArrowAzure::arrow_azure_static | ||
| AND ARROW_AZURE_BUNDLED_STATIC_LIBS | ||
| AND NOT TARGET ArrowAzure::arrow_azure_bundled_dependencies) | ||
| add_library(ArrowAzure::arrow_azure_bundled_dependencies STATIC IMPORTED) | ||
| get_target_property(arrow_azure_bundled_dependencies_link_libs | ||
| ArrowAzure::arrow_azure_static INTERFACE_LINK_LIBRARIES) | ||
| list(REMOVE_ITEM arrow_azure_bundled_dependencies_link_libs | ||
| ArrowAzure::arrow_azure_bundled_dependencies Arrow::arrow_static) | ||
| if(NOT WIN32) | ||
| list(APPEND arrow_azure_bundled_dependencies_link_libs OpenSSL::SSL OpenSSL::Crypto) | ||
| endif() | ||
| target_link_libraries(ArrowAzure::arrow_azure_bundled_dependencies | ||
| INTERFACE ${arrow_azure_bundled_dependencies_link_libs}) | ||
| get_target_property(arrow_azure_static_configurations ArrowAzure::arrow_azure_static | ||
| IMPORTED_CONFIGURATIONS) | ||
| foreach(CONFIGURATION ${arrow_azure_static_configurations}) | ||
| string(TOUPPER "${CONFIGURATION}" CONFIGURATION) | ||
| get_target_property(arrow_azure_static_location ArrowAzure::arrow_azure_static | ||
| IMPORTED_LOCATION_${CONFIGURATION}) | ||
| get_filename_component(arrow_azure_lib_dir "${arrow_azure_static_location}" | ||
| DIRECTORY) | ||
| set_property(TARGET ArrowAzure::arrow_azure_bundled_dependencies | ||
| APPEND | ||
| PROPERTY IMPORTED_CONFIGURATIONS ${CONFIGURATION}) | ||
| set_target_properties(ArrowAzure::arrow_azure_bundled_dependencies | ||
| PROPERTIES IMPORTED_LOCATION_${CONFIGURATION} | ||
| "${arrow_azure_lib_dir}/${CMAKE_STATIC_LIBRARY_PREFIX}arrow_azure_bundled_dependencies${CMAKE_STATIC_LIBRARY_SUFFIX}" | ||
| ) | ||
| endforeach() | ||
| endif() | ||
|
|
||
| arrow_keep_backward_compatibility(ArrowAzure arrow_azure) | ||
|
|
||
| check_required_components(ArrowAzure) | ||
|
|
||
| arrow_show_details(ArrowAzure ARROW_AZURE) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as GCS. GCS is tracked in #55284 , which covers GCS. @kou, should I create one for Azure for C GLib?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you do it, it's helpful. Or I can create it later. :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've created this one: