Repository navigation
Conversation
|
@github-actions crossbow submit test-conda-python-3.14-pandas-nightly-numpy-nightly |
|
@github-actions crossbow submit test-cuda-python-* |
|
Revision: 0b0547b Submitted crossbow builds: ursacomputing/crossbow @ actions-f4784d40eb
|
|
|
@github-actions crossbow submit cuda-python |
|
0b0547b to
d76834e
Compare
|
@github-actions crossbow submit test-conda-python-3.14-pandas-nightly-numpy-nightly |
|
Revision: d76834e Submitted crossbow builds: ursacomputing/crossbow @ actions-2c39a144ec
|
There was a problem hiding this comment.
🟡 Changes recommended
The NumPy <2.1 path still emits unhandled deprecation warnings and fails when warnings are treated as errors.
1 open issue
What changed in this PR
Addresses DLPack deprecation warnings in Python tests for GH-51481 without changing public APIs.
Changes:
- Filters expected warnings in two legacy-export tests.
- Adds a NumPy-version-aware helper for unsupported-export tests.
| File | Description |
|---|---|
| python/pyarrow/tests/test_dlpack.py | Adds warning filters and selects the DLPack capsule version by NumPy version. |
Review effort: Balanced
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
92b1b2f to
f64f711
Compare
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
4 open issues
The filter string includes a leading space afterignore:("ignore: Exporting..."), while other… · New This warning filter is broad because it omits the warning category (and optionally module). To… · New The NumPy version check runs every time the helper is invoked (including multiple calls within a… · Newfrom_dlpack_splitis not very descriptive about what is being “split” (it’s selecting a… · New
Review effort: Lite
| @check_bytes_allocated | ||
| @pytest.mark.parametrize('max_version', [None, (0, 8)]) | ||
| # Filter deprecation warning, already asserted in test_dlpack_legacy_capsule | ||
| @pytest.mark.filterwarnings("ignore: Exporting an unversioned DLPack") |
| @requires_numpy_version("2.1.0") | ||
| @check_bytes_allocated | ||
| @pytest.mark.parametrize('obj', dlpack_objects()) | ||
| @pytest.mark.filterwarnings("ignore: Exporting an unversioned DLPack") |
| def from_dlpack_split(obj): | ||
| if Version(np.__version__) < Version("2.1.0"): | ||
| max_version = None | ||
| else: | ||
| max_version = (1, 0) | ||
| return np.from_dlpack(DLPackForwarder(obj, max_version=max_version)) |
| def from_dlpack_split(obj): | ||
| if Version(np.__version__) < Version("2.1.0"): | ||
| max_version = None | ||
| else: | ||
| max_version = (1, 0) | ||
| return np.from_dlpack(DLPackForwarder(obj, max_version=max_version)) |



Rationale for this change
Deprecation warnings on our CI.
What changes are included in this PR?
Added filterwarning marks and updated two tests.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.
Was AI used for this PR?
PR code and description written by:
Reviewed before submission by: