Repository navigation
MINOR: [Dev] Ask for generative AI disclosure in PR template - #51282
Conversation
|
How about adding a checkbox instead? (This was partially generated, idea was mine)
Reviewed by:
|
|
I like the checkboxes, yeah! |
|
I would expect that sometimes even the PR description is written by AI. We can tell the submitters to respect the PR template if not properly written. |
kou
left a comment
There was a problem hiding this comment.
+1
I want to keep the "AI generation guidelines" link even if we use the suggested checkbox style.
We can tell the submitters to respect the PR template if not properly written.
It's out of scope of this PR but I want to automate it like our GH-XXX PR title check.
812b6e5 to
b327fe6
Compare
I suppose you gained a lot of productivity by generating this. Since multiple boxes can be checked in a list, I removed the superfluous "Human + AI" choices. |
|
To all reviewers: feel free to comment on the updated version! |
|
Looking at #51329 - should we expand this to issue templates? |
b327fe6 to
98acf7e
Compare
|
One small issue with the new checkboxes: GitHub treats |
|
@Reranko05 where is the message ( Maybe it's because is draft? I |
@raulcd I am referring to the circular task-progress tracker that appears on the PR page when the checkboxes are selected.
|
|
@raulcd Ah, I got it. It's because GitHub currently has two versions of the PR list. I am using the classic view, where the circular task-progress indicator is shown, while the new PR list doesn't show it. Both views are currently available. |
# Which issue does this PR close? <!-- It is not necessary to raise an issue, but it is encouraged if it is a non-trivial enhancement/bug. If this PR relates to an existing issue, but does not fully resolve it, please change the wording below from "Closes #NNN" to "Relates to #NNN" or "Part of #NNN" to avoid false closing an issue. --> None # Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. Please try to explain the problem you are trying to solve in terms of the user-visible behavior, rather than the implementation. --> The contributor guide asks contributors to disclose AI usage, but the PR template does not remind them to do so. Apache Arrow added a similar reminder in apache/arrow#51282. # What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> Add an AI usage disclosure section with brief guidance and a link to the contributor guide. Contributors can remove the section if they did not use AI tools. # Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests, if so identify these tests)? If this PR claims a performance improvement, please include evidence such as benchmark results. DO NOT simply paste a list of commands ran to verify the code; this is what our CI is for and it pollutes the PR. ONLY explain if testing was included with this PR, or why it wasn't. --> No. # Are there any significant user-facing changes? <!-- Significant user-facing changes include: - Breaking public API change - Significant change to existing functionality (e.g. function returns something different) These need to be explicitly called out to ensure we have proper documentation if required and to ensure we follow proper semantic versioning. DO NOT restate the changes of this PR; if a bug was fixed and already explained above, we don't need this to be restated as a user-facing change. --> No.


Rationale for this change
Often, PR submitters who evidently used AI don't disclose their usage of AI. This adds a nudge to the PR template that they should be upfront about their usage of AI.
The downside is that it's one more question to answer when submitting a PR.
Are these changes tested?
No.
Are there any user-facing changes?
No.