GH-51114: [FlightSQL][C++] Expose is_update field of PreparedStatement - #51133
GH-51114: [FlightSQL][C++] Expose is_update field of PreparedStatement#51133SHIVANSH-ux-ys wants to merge 3 commits into
Conversation
|
|
|
|
|
Thanks @lidavidm! Updated the PR title and description. Also added support to populate |
|
|
|
|
There was a problem hiding this comment.
I will do a deeper review tomorrow as I'm still familiarizing myself with the C++ codebase.
However, I don't see the same semantics as other PRs here. We need more than is_update being true/false, we need a presence check to know if the field was ever sent. This is important for backward compatibility (I assume most servers will not send this field).
The updates done to the tests also seem to not leave any test that doesn't set the field. IMO this is the most important test (again for backward compatibility).
@SHIVANSH-ux-ys I would like to preserve the true/false/unset semantics if possible.
|
Thanks for the cc @lidavidm |
Fixes #51114.
Exposes the
is_updateboolean field in the C++ Flight SQL layer:is_updatefield toActionCreatePreparedStatementResultinserver.hand updatedPackActionResultinserver.cc.bool is_update = falseparameter andis_update() constaccessor toPreparedStatementinclient.h/client.cc.PreparedStatement::ParseResponseto extractis_update.sqlite_server.cc) to populateis_updateviasqlite3_stmt_readonly.server_test.ccfor both query (ASSERT_FALSE) and update (ASSERT_TRUE) prepared statements.