Skip to content

GH-47583: [CI][Python] Enable PyArrow RelWithDebInfo build with assertions on Windows CI job #50406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
raulcd wants to merge 3 commits into
base: main
Choose a base branch
from
+14 −2
Open

GH-47583: [CI][Python] Enable PyArrow RelWithDebInfo build with assertions on Windows CI job #50406

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8f4d7ec
GH-47583: [CI][Python] Enable PyArrow Debug build on Windows CI job
raulcd Jul 7, 2026
f86e22e
Use RelWithDebInfo and try to strip -DNDEBUG
raulcd Jul 8, 2026
136c38d
Fix comment to be more accurate
raulcd Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions ci/scripts/python_build.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,14 @@ set ARROW_WITH_LZ4=ON
set ARROW_WITH_SNAPPY=ON
set ARROW_WITH_ZLIB=ON
set ARROW_WITH_ZSTD=ON
set CMAKE_BUILD_TYPE=Release
set CMAKE_BUILD_TYPE=RelWithDebInfo
set CMAKE_GENERATOR=Ninja
@rem Set CMAKE_CXX_FLAGS_RELWITHDEBINFO and CMAKE_C_FLAGS_RELWITHDEBINFO to
@rem override default /DNDEBUG to be dropped so assertions are maintained.
@rem A debug build would require linking against python3xx_d.lib (debug).
@rem See details of discussion on PR GH-50406
Comment thread
raulcd marked this conversation as resolved.
set CMAKE_CXX_FLAGS_RELWITHDEBINFO=/O2 /Ob1
set CMAKE_C_FLAGS_RELWITHDEBINFO=/O2 /Ob1
Comment thread
pitrou marked this conversation as resolved.
set CMAKE_UNITY_BUILD=ON

mkdir %CPP_BUILD_DIR%
Expand Down Expand Up @@ -97,6 +103,8 @@ cmake ^
-DARROW_WITH_ZLIB=%ARROW_WITH_ZLIB% ^
-DARROW_WITH_ZSTD=%ARROW_WITH_ZSTD% ^
-DCMAKE_BUILD_TYPE=%CMAKE_BUILD_TYPE% ^
-DCMAKE_C_FLAGS_RELWITHDEBINFO="%CMAKE_C_FLAGS_RELWITHDEBINFO%" ^
-DCMAKE_CXX_FLAGS_RELWITHDEBINFO="%CMAKE_CXX_FLAGS_RELWITHDEBINFO%" ^
-DCMAKE_INSTALL_PREFIX=%CMAKE_INSTALL_PREFIX% ^
-DCMAKE_UNITY_BUILD=%CMAKE_UNITY_BUILD% ^
-DMSVC_LINK_VERBOSE=ON ^
Expand Down Expand Up @@ -134,6 +142,10 @@ pushd %SOURCE_DIR%\python
%PYTHON_CMD% -m pip install -r requirements-build.txt || exit /B 1

@REM Build PyArrow
%PYTHON_CMD% -m pip install --no-deps --no-build-isolation -vv -C build.verbose=true . || exit /B 1
%PYTHON_CMD% -m pip install --no-deps --no-build-isolation -vv ^
-C build.verbose=true ^
-C cmake.build-type=%CMAKE_BUILD_TYPE% ^
-C cmake.define.CMAKE_C_FLAGS_RELWITHDEBINFO="%CMAKE_C_FLAGS_RELWITHDEBINFO%" ^
-C cmake.define.CMAKE_CXX_FLAGS_RELWITHDEBINFO="%CMAKE_CXX_FLAGS_RELWITHDEBINFO%" . || exit /B 1

popd
Loading