GH-49970: [GLib] Enable tests for custom extension data type - #49971
Merged
Conversation
|
|
Contributor
There was a problem hiding this comment.
Pull request overview
Enables previously omitted Ruby/GLib tests for a custom Arrow::ExtensionDataType now that the gobject-introspection Ruby bindings support implementing the required virtual methods.
Changes:
- Implement
virtual_do_get_extension_nameandvirtual_do_get_array_gtypein the test’s custom extension data type. - Remove
omit(...)calls so extension type behaviors (to_s,extension_name, wrapping arrays/chunked arrays) are exercised. - Fix chunked-array expectations to use
n_chunksandvalue_data_type.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+30
to
+36
| def virtual_do_get_extension_name | ||
| "uuid" | ||
| end | ||
|
|
||
| # TODO | ||
| # def get_array_gtype_impl | ||
| # UUIDArray.gtype | ||
| # end | ||
| def virtual_do_get_array_gtype | ||
| UUIDArray.gtype | ||
| end |
kou
force-pushed
the
glib-test-extension-data-type
branch
from
May 12, 2026 23:33
9d91616 to
fcabe47
Compare
kou
force-pushed
the
glib-test-extension-data-type
branch
from
May 20, 2026 05:11
fcabe47 to
aeed058
Compare
kou
force-pushed
the
glib-test-extension-data-type
branch
from
September 3, 2026 02:56
aeed058 to
631f1b1
Compare
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes are localized to GLib Ruby tests and align with existing virtual-method override patterns already used elsewhere in the test suite.
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0 new
- Review effort level: Lite
Member
Author
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
There are some omitted custom extension data type tests because gobject-introspection gem doesn't have enough features. But recent gobject-introspection gem provides these features.
What changes are included in this PR?
Enable omitted tests with recent gobject-introspection gem.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.