You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[C++][Parquet] Writer cleanup can crash after dictionary hash table resize fails with OOM #55628
If entries_builder_.Resize() inside UpsizeBuffer() fails, it returns before updating entries_.
Release — FinishWithLength() resets the builder. On the error return, local previous is destroyed, releasing the old buffer through PoolBuffer::~PoolBuffer():
pool_->Free(ptr, capacity_, alignment_);
Use after free — entries_ still points to the freed allocation. The file writer destructor calls Close(), and ColumnWriterImpl::Close() still attempts to write the dictionary:
if (has_dictionary_ && !fallback_) {
WriteDictionaryPage();
}
This reaches WriteDict() → CopyValues() → VisitEntries(), which dereferences the dangling pointer:
constauto& entry = entries_[i];
Expected: a failed write must not cause subsequent close/destruction to access freed memory or crash the process.
Activity