Repository navigation
Conversation
Contributor
Author
|
superceded by #11624 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
The existing unshredded object benchmarks (
variant_get_unshredded_object_path_262k_rows,shred_variant_*_object_8k_rows) repeat one metadata and value buffer for every row throughBinaryView. Data written one record at a time has its own metadata dictionary in each row, with different field names and different bytes. Writers that build each row independently, such asVariantArrayBuilder, produce this shape. A benchmark with shared metadata cannot show how a change behaves on that shape. For example, it favors caches keyed on the metadata pointer.What changes are included in this PR?
variant_get_per_row_metadata_{present,sparse,absent}_64k_rows: reads one field asInt32that every row, about 10% of rows, or no row has.shred_variant_per_row_metadata_8k_rows: shreds 5 fields from the same shape.Are these changes tested?
The benchmarks check the number of non-null results for each case before timing.
Are there any significant user-facing changes?
No.