Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/nanoarrow/common/array_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1267,6 +1267,19 @@ TEST(ArrayTest, ArrayTestAppendToBinaryArrayErrors) {
ArrowArrayRelease(&array);
}

TEST(ArrayTest, ArrayTestAppendToBinaryViewArrayErrors) {
struct ArrowArray array;

ASSERT_EQ(ArrowArrayInitFromType(&array, NANOARROW_TYPE_BINARY_VIEW), NANOARROW_OK);
EXPECT_EQ(ArrowArrayStartAppending(&array), NANOARROW_OK);
struct ArrowBufferView item;
item.data.as_char = "";
item.size_bytes = static_cast<int64_t>(INT32_MAX) + 1;
EXPECT_EQ(ArrowArrayAppendBytes(&array, item), EOVERFLOW);

ArrowArrayRelease(&array);
}

TEST(ArrayTest, ArrayTestAppendToIntervalArrayYearMonth) {
struct ArrowArray array;

Expand Down
4 changes: 4 additions & 0 deletions src/nanoarrow/common/inline_array.h
Original file line number Diff line number Diff line change
Expand Up @@ -584,6 +584,10 @@ static inline ArrowErrorCode ArrowArrayAppendBytes(struct ArrowArray* array,

if (private_data->storage_type == NANOARROW_TYPE_STRING_VIEW ||
private_data->storage_type == NANOARROW_TYPE_BINARY_VIEW) {
if (value.size_bytes > INT32_MAX) {
return EOVERFLOW;
}

struct ArrowBuffer* data_buffer = ArrowArrayBuffer(array, 1);
union ArrowBinaryView bvt;
bvt.inlined.size = (int32_t)value.size_bytes;
Expand Down
Loading