Skip to content

chore: Remove unnecessary use of __COUNTER__ - #853

Merged
paleolimbot merged 2 commits into
apache:mainfrom
paleolimbot:counter-update
Mar 6, 2026
Merged

paleolimbot merged 2 commits into
apache:mainfrom
paleolimbot:counter-update

Conversation

@paleolimbot

Copy link
Copy Markdown
Member

In apache/arrow-adbc#4044, ADBC has to work around a clang warning that declares __COUNTER__ an extension. We don't strictly need it here so I just removed the usage. Claude Opus seems to think this is safe because of the do { ... } while(0); scoping but alternative opinions are welcome!

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.84%. Comparing base (f11d517) to head (53db582).
⚠️ Report is 21 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #853      +/-   ##
==========================================
- Coverage   79.96%   79.84%   -0.13%     
==========================================
  Files         105      106       +1     
  Lines       15461    15633     +172     
  Branches     1738     1742       +4     
==========================================
+ Hits        12364    12482     +118     
- Misses       1998     2051      +53     
- Partials     1099     1100       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

matrix:
config:
- {os: macOS-latest, r: 'release'}
- {os: windows-latest, r: '4.1'}

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The action we were using to install R no longer supports R 4.1 (released in 2021), so I think we can drop official support.

@paleolimbot
paleolimbot marked this pull request as ready for review March 5, 2026 20:56
@paleolimbot
paleolimbot merged commit af347fa into apache:main Mar 6, 2026
42 checks passed
@paleolimbot
paleolimbot deleted the counter-update branch March 6, 2026 03:02
@paleolimbot paleolimbot added this to the nanoarrow 0.9.0 milestone Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants