Repository navigation
fix(python): Preserve negative decimal values during iteration - #1008
Merged
paleolimbot merged 1 commit intoNov 11, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Negative decimal128 and decimal256 values become enormous positive values during Python conversion. The stored integer is signed, but
_decimal_iter()currently decodes it as unsigned. This addssigned=Trueat that conversion boundary.The regression tests cover both widths, negative and positive values, nulls, zero, varied scales and full precision under modified decimal contexts.
Tested with a rebuilt source wheel on macOS arm64/Python 3.14: 276 tests passed, 4 skipped; 118 doctests passed; stubtest passed for eight modules; applicable pre-commit hooks passed. The decimal regressions failed before the change. Other platforms and Python versions remain for CI.
AI assistance: Codex generated the fix and tests and ran the local checks.