Repository navigation
fix: validate list-view size buffers - #1003
Merged
paleolimbot merged 3 commits intoNov 9, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1003 +/- ##
=======================================
Coverage 78.48% 78.48%
=======================================
Files 106 106
Lines 17244 17245 +1
Branches 2065 2065
=======================================
+ Hits 13534 13535 +1
Misses 2446 2446
Partials 1264 1264 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
paleolimbot
reviewed
Nov 6, 2026
paleolimbot
left a comment
Member
There was a problem hiding this comment.
Thank you!
If you don't mind reverting the R fix, I believe we have that solved on main now.
Comment on lines
+41
to
+44
| # str() spacing differs between R versions. | ||
| normalize_str_output <- function(x) { | ||
| gsub(": (List of|<nanoarrow_buffer)", ":\\1", x) | ||
| } |
Member
There was a problem hiding this comment.
I fixed this one in a separate PR...I think you can revert this!
Keep the ListView size-buffer fix and regression tests while preserving upstream overflow, unaligned-access, and IPC changes. Use the R printing fix and snapshots from apache#1007 instead of the PR-specific test transform. Generated-by: Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minimal validation only checks the first two buffers, so it misses the sizes buffer in ListView and LargeListView arrays. Include that fixed-size third buffer to reject missing or truncated sizes before full validation reads them, and infer its size when unknown. Regression tests cover both types, sliced arrays, and empty arrays. R array-print snapshots also normalise version-dependent separator spacing from
str().Debug and ASan/UBSan CTest builds each passed 298 tests, with 3 thread-safety tests skipped by the build configuration. The sanitizer run used
ASAN_OPTIONS=allocator_may_return_null=1:detect_leaks=0for tests that deliberately request oversized allocations. clang-format 16.0.6, codespell 2.2.5 andgit diff --checkpassed. The R-devel check passed on GitHub with 1,762 expectations and no failures or warnings.Codex generated the fix and regression tests and ran the local checks.