MINOR: Don't install Homebrew's Node.js for JNI macOS build - #1270
Merged
Merged
Conversation
Homebrew doesn't provide a bottle for node on x86_64 macOS because Homebrew treats x86_64 macOS as a tier 3 configuration. So "brew bundle --file=arrow/cpp/Brewfile" fails with "node: no bottle available!" and the "JNI macos-15-intel x86_64" job can't install dependencies. We don't need Node.js for the JNI build. So we skip installing it like we already do for aws-sdk-cpp and gRPC.
jbonofre
requested review from
kou,
laurentgo,
lidavidm and
wgtmac
as code owners
August 30, 2026 16:23
Member
Author
lidavidm
approved these changes
Aug 30, 2026
This was referenced Sep 21, 2026
kou
pushed a commit
that referenced
this pull request
Sep 21, 2026
### Rationale for this change Homebrew treats x86_64 macOS as a [tier 3 configuration](https://docs.brew.sh/Support-Tiers#tier-3) and rarely builds bottles for it. `brew bundle` doesn't build from source, so the `JNI macos-15-intel x86_64` job in the RC workflow aborts in `Install dependencies` with `no bottle available!` before anything is compiled. We've been patching this formula by formula: * #1269 skipped `aws-sdk-cpp` and gRPC. * #1270 skipped Node.js. Any new dependency added to `apache/arrow`'s `cpp/Brewfile` can break the job again the same way, and nightly RC runs go red on `main` when it does. We can't keep this job green on a configuration Homebrew doesn't support. #1269 noted that dropping the `macos-15-intel` entry needed its own discussion because it's user-facing. #1305 is that discussion. ### What changes are included in this PR? `rc.yml`: * Removed the `macos-15-intel` / `x86_64` entry from the `jni-macos` matrix. * `binaries` no longer extracts `jni-macos-x86_64.tar.gz` nor asserts the four `jni/*/x86_64/*.dylib` files. * Dropped the `/usr/local` `python@XXX --overwrite` conflict loop. Its comment already said it could go once we dropped `macos-15-intel`, since `macos-14` and later on arm64 use `/opt/homebrew`. `brew update` is kept. * Unwrapped the `pkg-config` uninstall from its `if [ "$(uname -m)" = "arm64" ]` guard, which is now always true. * Trimmed the tier-3 justification from the `HOMEBREW_BUNDLE_BREW_SKIP` comment. The skip list itself is unchanged: `aws-sdk-cpp` and gRPC are still skipped so the bundled static ones are used, and Node.js is still skipped because the JNI build doesn't need it. `test.yml`: * Removed the `AMD64` / `macos-15-intel` entry from the `macos` test matrix, leaving `AArch64` on `macos-latest`. `ci/scripts/jni_macos_build.sh` is untouched, so building the JNI libraries locally on an Intel Mac still works. ### Are these changes tested? Yes, by CI. The remaining `JNI macos-14 aarch_64` job exercises the changed `Install dependencies` step, and `binaries` exercises the changed artifact extraction and verification. ### Are there any user-facing changes? Yes. Release JARs no longer bundle x86_64 macOS `.dylib` files for `arrow_cdata_jni`, `arrow_dataset_jni`, `arrow_orc_jni` and `gandiva_jni`. Intel Mac users of those modules will need to build the JNI libraries themselves. aarch64 macOS, x86_64 and aarch64 Linux, and x86_64 Windows are unaffected. Closes #1305.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
JNI macos-15-intel x86_64job currently fails onmainand on every open PR while installing dependencies:apache/arrow'scpp/Brewfilelistsbrew "node", and Homebrew treats x86_64 macOS as a tier 3 configuration and no longer builds a bottle for it.brew bundledoesn't build from source, so the step aborts before anything is built.We don't need Node.js for the JNI build, so this skips installing it via
HOMEBREW_BUNDLE_BREW_SKIP, the same way #1269 did foraws-sdk-cppand gRPC.Failing runs for reference:
main: https://github.com/apache/arrow-java/actions/runs/33283736388/job/99183221397