fix: allow POST for connector redirect route - #1612
Open
DanielAuerX wants to merge 1 commit into
Open
Conversation
Connector plugins that collect credentials in a login form (e.g. an LDAP connector) need to submit them via POST rather than GET, since GET params get logged in server/proxy access logs and browser history. ConnectorRedirectDispatcher itself is already method-agnostic (it just reads ctx.Request), so this only needed a route registration change. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connector plugins that collect credentials in a login form (e.g. an LDAP connector) need to submit them via POST rather than GET.
ConnectorRedirectDispatcher itself is already method-agnostic (it just reads ctx.Request), so this only needed a route registration change.
Related to apache/answer-plugins#294 (LDAP connector), which needs this to submit login credentials safely.