-
Notifications
You must be signed in to change notification settings - Fork 368
[AMORO-4022] [Improvement]: AMS Iceberg maintainer moved to the amoro-iceberg module #4024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
4c279f9 to
38ddfe5
Compare
764e8e6 to
19c989f
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #4024 +/- ##
============================================
+ Coverage 22.12% 22.44% +0.31%
- Complexity 2461 2554 +93
============================================
Files 445 458 +13
Lines 40897 42065 +1168
Branches 5767 5909 +142
============================================
+ Hits 9050 9441 +391
- Misses 31089 31812 +723
- Partials 758 812 +54
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4becf57 to
658adbf
Compare
baiyangtx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for your improvement.
...-ams/src/main/java/org/apache/amoro/server/optimizing/maintainer/TableMaintainerFactory.java
Outdated
Show resolved
Hide resolved
amoro-ams/src/main/java/org/apache/amoro/server/optimizing/maintainer/TableMaintainers.java
Outdated
Show resolved
Hide resolved
| import org.apache.amoro.data.ChangeAction; | ||
| import org.apache.amoro.data.DataFileType; | ||
| import org.apache.amoro.data.PrimaryKeyedFile; | ||
| import org.apache.amoro.formats.iceberg.maintainer.IcebergTableMaintainer; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move those Tests to iceberg-format module?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried my best, but it didn't work because it relies on other components such as ExecutorBaseTest and AMS, which have a large number of other dependencies within AMS. The executor of Maintainer is currently in AMS, and in the future we can implement an implementation based on external engine scheduling(next pr).
5492f72 to
c3c426c
Compare
[AMORO-4022] [Improvement]: AMS Iceberg maintainer moved to the amoro-iceberg module (#4022)
Why are the changes needed?
Close #4022 .
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation