[Feature]: Support LDAP Authentication for Dashboard Login #4009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davedwwang
force-pushed
the
dev/ldap_auth
branch
2 times, most recently
from
49085d4 to
4822529
Compare
github-actions
bot
added
the
type:docs
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4009 +/- ##
============================================
+ Coverage 22.12% 22.85% +0.72%
- Complexity 2461 2531 +70
============================================
Files 445 449 +4
Lines 40897 41048 +151
Branches 5767 5784 +17
============================================
+ Hits 9050 9380 +330
+ Misses 31089 30859 -230
- Partials 758 809 +51
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
davedwwang
force-pushed
the
dev/ldap_auth
branch
2 times, most recently
from
cea2c1a to
e986923
Compare
davedwwang
force-pushed
the
dev/ldap_auth
branch
2 times, most recently
from
1ef3f63 to
9bfc2e1
Compare
Contributor
Author
|
hi @turboFei Would you mind reviewing this? I’d really appreciate it. Thanks! |
turboFei
reviewed
Dec 30, 2025
| dashboardServer.getLoginAuthProvider().authenticate(credential); | ||
| } catch (Exception e) { | ||
| LOG.error("authenticate user {} failed", user, e); | ||
| throw new RuntimeException("invalid user " + user + " or password!"); |
Member
There was a problem hiding this comment.
return the cause message as well
| cn: user1 | ||
| sn: Ldap | ||
| uid: ldaptest1 | ||
| userPassword: 12345 No newline at end of file |
| private final PasswdAuthenticationProvider basicAuthProvider; | ||
| private final TokenAuthenticationProvider jwtAuthProvider; | ||
|
|
||
| private final PasswdAuthenticationProvider loginAuthProvider; |
Member
There was a problem hiding this comment.
how about moving the loginAuthProvider into LoginController?
| String pwd = bodyParams.get("password"); | ||
| if (adminUser.equals(user) && (adminPassword.equals(pwd))) { | ||
| ctx.sessionAttribute("user", new SessionInfo(adminUser, System.currentTimeMillis() + "")); | ||
| ctx.json(OkResponse.of("success")); |
Member
There was a problem hiding this comment.
Seems this part of logic is missed after dashboardServer.getLoginAuthProvider().authenticate(credential);
|
|
||
| public LdapPasswdAuthenticationProvider(Configurations conf) { | ||
| this.ldapUrl = conf.get(AmoroManagementConf.HTTP_SERVER_LOGIN_AUTH_LDAP_URL); | ||
| this.ldapUserParttern = conf.get(AmoroManagementConf.HTTP_SERVER_LOGIN_AUTH_LDAP_USERPARTTERN); |
Member
There was a problem hiding this comment.
check the ldapUrl and ldapUserParttern non empty
| // ok | ||
| Map<String, String> bodyParams = ctx.bodyAsClass(Map.class); | ||
| String user = bodyParams.get("user"); | ||
| String pwd = bodyParams.get("password"); |
Member
There was a problem hiding this comment.
check the user and pwd non empty
davedwwang
force-pushed
the
dev/ldap_auth
branch
4 times, most recently
from
5877520 to
9644ad2
Compare
davedwwang
force-pushed
the
dev/ldap_auth
branch
from
9644ad2 to
3ee9051
Compare
turboFei
reviewed
Jan 4, 2026
|
|
||
| private final PasswdAuthenticationProvider basicAuthProvider; | ||
| private final TokenAuthenticationProvider jwtAuthProvider; | ||
|
|
| "User-defined login authentication implementation of" | ||
| + " org.apache.amoro.authentication.PasswdAuthenticationProvider"); | ||
|
|
||
| public static final ConfigOption<String> HTTP_SERVER_LOGIN_AUTH_LDAP_USERPARTTERN = |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
The current Dashboard login uses an admin-user with a plaintext password, which is highly insecure. To enhance security, centralize user management, and align with industry standard practices, we need to switch to LDAP authentication.
Close #4008.
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Run test locally before making a pull request
Documentation