Document LLMFileAnalysisOperator's inherited LLM and HITL parameters - #71856
Open
ColtenOuO wants to merge 1 commit into
Open
Document LLMFileAnalysisOperator's inherited LLM and HITL parameters#71856ColtenOuO wants to merge 1 commit into
ColtenOuO wants to merge 1 commit into
Conversation
model_id, system_prompt, agent_params, and the require_approval / approval_timeout / allow_modifications trio are fully supported here but undocumented in the docstrings, unlike every sibling operator (LLMSQLQueryOperator, LLMBranchOperator, LLMSchemaCompareOperator), which document them and show a require_approval example.
ColtenOuO
requested review from
Lee-W,
ashb,
gopidesupavan and
kaxil
as code owners
August 19, 2026 22:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LLMFileAnalysisOperatorfully supportsmodel_id,system_prompt,agent_params, and HITL review (require_approval,approval_timeout,allow_modifications) - all inherited fromLLMOperatorand exercised inexecute(), but its docstringdocumented none of them, unlike
LLMSQLQueryOperator,LLMBranchOperator, andLLMSchemaCompareOperator, which all document these plus a require_approval example.This is a docs-only change; no behavior changes.
Change
operators/llm_file_analysis.py: added:param model_id:,:param system_prompt:,:param agent_params:entries toLLMFileAnalysisOperator's docstring, plus the "Human-in-the-Loop approval parameters are inherited from LLMOperator..." paragraph every sibling operator already has.decorators/llm_file_analysis.py: expanded_LLMFileAnalysisDecoratedOperator's one-line docstring to match the fuller format used by_LLMBranchDecoratedOperator/_LLMSQLDecoratedOperator.example_dags/example_llm_file_analysis.py: addedexample_llm_file_analysis_approval, demonstratingrequire_approval=Truethis was the only file-analysis-family example DAG missing an approval example.docs/operators/llm_file_analysis.rst: added a "Human-in-the-Loop Approval" section wiring the new example into the built docs, mirroringllm_sql.rst.Was generative AI tooling used to co-author this PR?