Restrict MSGraph deferrable pagination to the configured host - #71842
Open
FrankYang0529 wants to merge 1 commit into
Open
Restrict MSGraph deferrable pagination to the configured host#71842FrankYang0529 wants to merge 1 commit into
FrankYang0529 wants to merge 1 commit into
Conversation
FrankYang0529
force-pushed
the
airflow-msgraph-pagination-host-guard
branch
from
August 20, 2026 03:34
536a7b7 to
c8f00af
Compare
Signed-off-by: PoAn Yang <payang@apache.org>
FrankYang0529
force-pushed
the
airflow-msgraph-pagination-host-guard
branch
from
August 20, 2026 04:08
c8f00af to
cdde34f
Compare
FrankYang0529
marked this pull request as ready for review
August 20, 2026 05:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
MSGraphAsyncOperatorfetches the next page, the url comes from the previous response. The Kiota adapter attaches the connection's access token to every request it sends. Nothing checks that url before the request goes out.How
paginated_run()already does (added in Restrict MSGraph pagination nextLink to the configured host #69742) intoKiotaRequestAdapterHook.assert_allowed_host(). The allowed host comes from the request adapter'sbase_url.pagination_link: bool = FalsetoMSGraphTrigger, carry it throughserialize(), and call the helper at the top ofrun()when it is set.MSGraphAsyncOperator.trigger_next_link()passespagination_link=True, so the check applies only to urls that came back from a response.$top/$skipbranch and a custompagination_functioncan both produce one, soassert_allowed_host()returns early for any url that is not absolute.Verification
uv run --project providers/microsoft/azure pytest providers/microsoft/azure/tests/unit/microsoft/azure -k msgraphWas generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.