Helm: Fix PgBouncer hostname for result backend under standard naming - #71830
Open
dheerenmohta wants to merge 1 commit into
Open
Helm: Fix PgBouncer hostname for result backend under standard naming#71830dheerenmohta wants to merge 1 commit into
dheerenmohta wants to merge 1 commit into
Conversation
The result backend connection secret built the PgBouncer hostname from `.Release.Name` directly and omitted the namespace, unlike the metadata connection secret's equivalent logic. Once `useStandardNaming` is enabled (the chart's own recommended setting for new installs) or a `fullnameOverride` is set, the computed hostname no longer matches the actual PgBouncer Service name, so Celery result-backend traffic silently fails to route through PgBouncer. Derive the host the same way the metadata secret already does, via the `airflow.fullname` template plus namespace, so both secrets stay consistent and resolve correctly regardless of naming configuration.
dheerenmohta
requested review from
Miretpl,
bugraoz93,
hussein-awala,
jedcunningham and
jscheffl
as code owners
August 19, 2026 10:15
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The auto-generated result-backend connection secret built the PgBouncer hostname from .Release.Name directly, omitting the namespace — unlike the already-correct sibling logic in the metadata connection secret. This silently breaks Celery result-backend to PgBouncer routing whenever useStandardNaming (the chart's own recommended setting) or fullnameOverride is used, since the rendered PgBouncer Service name diverges from .Release.Name.
Derives the PgBouncer host the same way the metadata secret already does, and adds a regression test covering the useStandardNaming: true case.
Note: this does not fully resolve #54875's original ask. Auto-configuring PgBouncer when the metadata connection is backed by an externally-managed, opaque Kubernetes Secret isn't something Helm templating can do, since it can't introspect that Secret's contents at render time. This fixes a real, narrower, verified bug in the chart's own auto-generated-secret path.
related: #54875
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Sonnet 5) following the guidelines