Fix XCom get_value outside task runner#68789
Open
sdhilip200 wants to merge 1 commit into
Open
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
BaseXCom.get_value()is called outside a task-runner context, such as from plugin extra links resolved by the API server,BaseXCom.get_one()attempted to importSUPERVISOR_COMMSand raisedImportErrorbefore it could read the stored XCom value.This changes sync
BaseXCom.get_one()to keep using supervisor comms when they are available, and to fall back to reading the matching XCom row from the metadata database when no supervisor comms are present. The fallback usesXComModel.deserialize_value()so DB-backed values are decoded consistently with the model path.Closes #59093
Tests:
uv run pytest airflow-core/tests/unit/models/test_xcom.py::TestXComGet::test_basexcom_get_value_reads_from_db_without_supervisor_commsuv run pytest airflow-core/tests/unit/models/test_xcom.py::TestXComGetuv run pytest task-sdk/tests/task_sdk/bases/test_xcom.pyuv run pytest airflow-core/tests/unit/models/test_xcom.pyuv run ruff check task-sdk/src/airflow/sdk/bases/xcom.py airflow-core/tests/unit/models/test_xcom.pyuv run ruff format --check task-sdk/src/airflow/sdk/bases/xcom.py airflow-core/tests/unit/models/test_xcom.pyWas generative AI tooling used to co-author this PR?
Generated-by: OpenAI Codex following the guidelines at https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions