Skip to content

Fix XCom get_value outside task runner#68789

Open
sdhilip200 wants to merge 1 commit into
apache:mainfrom
sdhilip200:codex/fix-xcom-extra-link-context
Open

Fix XCom get_value outside task runner#68789
sdhilip200 wants to merge 1 commit into
apache:mainfrom
sdhilip200:codex/fix-xcom-extra-link-context

Conversation

@sdhilip200

@sdhilip200 sdhilip200 commented Jun 21, 2026

Copy link
Copy Markdown

When BaseXCom.get_value() is called outside a task-runner context, such as from plugin extra links resolved by the API server, BaseXCom.get_one() attempted to import SUPERVISOR_COMMS and raised ImportError before it could read the stored XCom value.

This changes sync BaseXCom.get_one() to keep using supervisor comms when they are available, and to fall back to reading the matching XCom row from the metadata database when no supervisor comms are present. The fallback uses XComModel.deserialize_value() so DB-backed values are decoded consistently with the model path.

Closes #59093

Tests:

  • uv run pytest airflow-core/tests/unit/models/test_xcom.py::TestXComGet::test_basexcom_get_value_reads_from_db_without_supervisor_comms
  • uv run pytest airflow-core/tests/unit/models/test_xcom.py::TestXComGet
  • uv run pytest task-sdk/tests/task_sdk/bases/test_xcom.py
  • uv run pytest airflow-core/tests/unit/models/test_xcom.py
  • uv run ruff check task-sdk/src/airflow/sdk/bases/xcom.py airflow-core/tests/unit/models/test_xcom.py
  • uv run ruff format --check task-sdk/src/airflow/sdk/bases/xcom.py airflow-core/tests/unit/models/test_xcom.py

Was generative AI tooling used to co-author this PR?
  • Yes: OpenAI Codex

Generated-by: OpenAI Codex following the guidelines at https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions

@boring-cyborg

boring-cyborg Bot commented Jun 21, 2026

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example Dag that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@sdhilip200 sdhilip200 marked this pull request as ready for review June 21, 2026 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

XCom.get_value() via SDK fails in extra link plugin with SUPERVISOR_COMMS ImportError

1 participant