-
Notifications
You must be signed in to change notification settings - Fork 17.3k
Show clear error for invalid sql_alchemy_conn at startup #68783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
GayathriSrividya
wants to merge
1
commit into
apache:main
Choose a base branch
from
GayathriSrividya:fix/invalid-sqlalchemy-uri-help-cli-68707
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+76
−1
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -500,3 +500,58 @@ def test_early_return_when_all_none(self): | |
| settings.dispose_orm(do_log=False) | ||
|
|
||
| mock_close.assert_not_called() | ||
|
|
||
|
|
||
| class TestGetAsyncConnUriFromSync: | ||
| """Tests for _get_async_conn_uri_from_sync function.""" | ||
|
|
||
| def test_sqlite_uri_conversion(self): | ||
| """Test conversion of SQLite sync URI to async with aiosqlite.""" | ||
| result = settings._get_async_conn_uri_from_sync("sqlite:///path/to/db.sqlite") | ||
| assert result == "sqlite+aiosqlite:///path/to/db.sqlite" | ||
|
|
||
| def test_postgresql_uri_conversion(self): | ||
| """Test conversion of PostgreSQL sync URI to async with asyncpg.""" | ||
| result = settings._get_async_conn_uri_from_sync("postgresql://user:pass@localhost/dbname") | ||
| assert result == "postgresql+asyncpg://user:pass@localhost/dbname" | ||
|
|
||
| def test_mysql_uri_conversion(self): | ||
| """Test conversion of MySQL sync URI to async with aiomysql.""" | ||
| result = settings._get_async_conn_uri_from_sync("mysql://user:pass@localhost/dbname") | ||
| assert result == "mysql+aiomysql://user:pass@localhost/dbname" | ||
|
|
||
| def test_postgresql_psycopg2_uri_conversion(self): | ||
| """Test conversion of PostgreSQL with psycopg2 driver to asyncpg.""" | ||
| result = settings._get_async_conn_uri_from_sync("postgresql+psycopg2://user@localhost/db") | ||
| assert result == "postgresql+asyncpg://user@localhost/db" | ||
|
|
||
| def test_unsupported_scheme_returns_original_uri(self): | ||
| """Test that unsupported schemes return the original URI unchanged.""" | ||
| uri = "oracle://user:pass@localhost:1521/dbname" | ||
| result = settings._get_async_conn_uri_from_sync(uri) | ||
| assert result == uri | ||
|
|
||
| def test_empty_string_raises_value_error(self): | ||
| """Test that empty string raises ValueError with helpful message.""" | ||
| with pytest.raises(ValueError, match="Invalid SQLAlchemy connection URI"): | ||
| settings._get_async_conn_uri_from_sync("") | ||
|
|
||
| def test_none_raises_value_error(self): | ||
| """Test that None raises ValueError with helpful message.""" | ||
| with pytest.raises(ValueError, match="Invalid SQLAlchemy connection URI"): | ||
| settings._get_async_conn_uri_from_sync(None) | ||
|
|
||
| def test_malformed_uri_without_colon_raises_value_error(self): | ||
| """Test that URI without ':' separator raises ValueError.""" | ||
| with pytest.raises(ValueError, match="Invalid SQLAlchemy connection URI.*':' separator"): | ||
| settings._get_async_conn_uri_from_sync("notavaliduri") | ||
|
Comment on lines
+534
to
+547
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we can do the same with these tests as well. |
||
|
|
||
| def test_error_message_is_helpful(self): | ||
| """Test that error message contains helpful guidance.""" | ||
| with pytest.raises(ValueError, match="Invalid SQLAlchemy connection URI") as exc_info: | ||
| settings._get_async_conn_uri_from_sync("invalid_value") | ||
|
|
||
| error_msg = str(exc_info.value) | ||
| assert "AIRFLOW__DATABASE__SQL_ALCHEMY_CONN" in error_msg | ||
| assert "sql_alchemy_conn" in error_msg | ||
| assert "airflow.cfg" in error_msg | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it maybe make sense to parameterize these tests? It could be tightened up to something like: