Skip to content

Add global labels to helm chart priorityclasses #68759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Aakcht wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −0
Open

Add global labels to helm chart priorityclasses #68759

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions chart/templates/priorityclasses/priority-classes.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,9 @@ metadata:
release: {{ $Global.Release.Name }}
chart: "{{ $Global.Chart.Name }}-{{ $Global.Chart.Version }}"
heritage: {{ $Global.Release.Service }}
{{- with $Global.Values.labels }}
{{- toYaml . | nindent 4 }}
{{- end }}
preemptionPolicy: {{ default "PreemptLowerPriority" $e.preemptionPolicy }}
value: {{ $e.value | required "value is required for priority classes" }}
description: "This priority class will not cause other pods to be preempted."
Expand Down
4 changes: 4 additions & 0 deletions chart/tests/helm_tests/airflow_aux/test_basic_helm_chart.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,9 @@ def test_labels_are_valid(self, executor):
"logs": {"persistence": {"enabled": True}},
"dags": {"persistence": {"enabled": True}},
"postgresql": {"enabled": False}, # We won't check the objects created by the postgres chart
"priorityClasses": [
{"name": "class1", "value": 10000},
],
}

k8s_objects = render_chart(name=release_name, values=values)
Expand Down Expand Up @@ -303,6 +306,7 @@ def test_labels_are_valid(self, executor):
(f"{release_name}-airflow-api-server", "ServiceAccount", "api-server"),
(f"{release_name}-api-secret-key", "Secret", "api-server"),
(f"{release_name}-api-server-policy", "NetworkPolicy", "airflow-api-server-policy"),
(f"{release_name}-class1", "PriorityClass", None),
]

cleanup_kubernetes_executor_only_objects = {
Expand Down
Loading