Fix /tmp file leak when API server streams large task logs#66450
Open
dheerajturaga wants to merge 1 commit intoapache:mainfrom
Open
Fix /tmp file leak when API server streams large task logs#66450dheerajturaga wants to merge 1 commit intoapache:mainfrom
dheerajturaga wants to merge 1 commit intoapache:mainfrom
Conversation
LogStreamAccumulator spills the in-flight log stream to a NamedTemporaryFile(delete=False) in /tmp once a task's output exceeds 5000 lines. Cleanup was hooked only into the stream generator's finally block, so the file leaked whenever the caller did not iterate the generator to completion: client disconnect on the NDJSON streaming endpoint, exception during list() materialisation on the JSON path, or the caller using only total_lines and never accessing .stream. A single production host accumulated ~39 GB of orphaned files from this code path, with individual files up to 2.5 GB on tasks emitting ~10M log lines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LogStreamAccumulator spills the in-flight log stream to a
NamedTemporaryFile(delete=False) in /tmp once a task's output exceeds
5000 lines. Cleanup was hooked only into the stream generator's
finally block, so the file leaked whenever the caller did not iterate
the generator to completion: client disconnect on the NDJSON streaming
endpoint, exception during list() materialisation on the JSON path, or
the caller using only total_lines and never accessing .stream.
A single production host accumulated ~39 GB of orphaned files from this
code path, with individual files up to 2.5 GB on tasks emitting
~10M log lines.
Was generative AI tooling used to co-author this PR?
ClaudeCode Opus 4.7