Skip to content

Add CeleryExecutor callback workload routing test #66435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leeyspaul wants to merge 1 commit into
base: main
Choose a base branch
from
+37 −0
Open

Add CeleryExecutor callback workload routing test #66435

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions providers/celery/tests/unit/celery/executors/test_celery_executor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -885,6 +885,43 @@ def test_celery_tasks_registered_on_import():
)


@pytest.mark.skipif(not AIRFLOW_V_3_2_PLUS, reason="ExecuteCallback requires Airflow 3.2+")
@pytest.mark.parametrize(
("callback_data", "expected_queue"),
[
pytest.param({"path": "tests.callbacks.test_callback", "kwargs": {}}, "default", id="default_queue"),
pytest.param(
{"path": "tests.callbacks.test_callback", "kwargs": {}, "queue": "callback_queue"},
"callback_queue",
id="callback_queue",
),
],
)
@mock.patch("airflow.providers.celery.executors.celery_executor.CeleryExecutor._send_workloads")
def test_process_workloads_routes_execute_callback(mock_send_workloads, callback_data, expected_queue):
"""CeleryExecutor routes callback workloads to Celery with the expected queue."""
from airflow.executors import workloads
from airflow.executors.workloads.callback import CallbackDTO

callback_id = "00000000-0000-0000-0000-000000000003"
workload = workloads.ExecuteCallback(
callback=CallbackDTO(
id=callback_id,
fetch_method=workloads.CallbackFetchMethod.IMPORT_PATH,
data=callback_data,
),
dag_rel_path="test_dag.py",
bundle_info=workloads.BundleInfo(name="test-bundle", version=None),
token="test-token",
log_path="callback.log",
)

executor = celery_executor.CeleryExecutor()
executor._process_workloads([workload])

mock_send_workloads.assert_called_once_with([(callback_id, workload, expected_queue, None)])


@pytest.mark.skipif(not AIRFLOW_V_3_0_PLUS, reason="execute_workload is only used for Airflow 3+")
@pytest.mark.skipif(AIRFLOW_V_3_3_PLUS, reason="pre-3.3 compatibility path only applies before Airflow 3.3")
def test_execute_workload_runs_execute_task_before_airflow_3_3():
Expand Down
Loading