Fix None-valued OTel span attributes in triggerer#66411
Open
jakubmatyszewski wants to merge 1 commit intoapache:mainfrom
Open
Fix None-valued OTel span attributes in triggerer#66411jakubmatyszewski wants to merge 1 commit intoapache:mainfrom
jakubmatyszewski wants to merge 1 commit intoapache:mainfrom
Conversation
3156867 to
75fb460
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed following error in triggerer logs:
I've compared implementation of
_make_trigger_span* with_make_task_span* and my guess is that it failed due tomap_indexbeingNone.Proposed fix filters out
Nonevalues before building the attributes dict.Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.