Fix priority_weight NOT NULL constraint in provider tests
#59833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:apache-spark
provider:apache-kylin
provider:cncf-kubernetes
uranusjr
approved these changes
Dec 26, 2025
Member
|
I’m doing a fix in a more blanket way in #59835, but eventually we should fix all tests to do this instead. |
Collaborator
Author
Dev-iL
force-pushed
the
2512/fix_priority_weight
branch
from
a9a0da2 to
f9a9434
Compare
potiuk
approved these changes
Dec 27, 2025
Member
Dev-iL
force-pushed
the
2512/fix_priority_weight
branch
from
f9a9434 to
8654ba1
Compare
Dev-iL
requested review from
amoghrajesh,
ashb,
bolkedebruin and
kaxil
as code owners
Dev-iL
force-pushed
the
2512/fix_priority_weight
branch
from
8654ba1 to
3122c97
Compare
Collaborator
Author
Dev-iL
force-pushed
the
2512/fix_priority_weight
branch
from
3122c97 to
dcd9918
Compare
amoghrajesh
approved these changes
Dec 29, 2025
Contributor
amoghrajesh
left a comment
amoghrajesh
left a comment
There was a problem hiding this comment.
Just a nit, otherwise LGTM
After commit 60b4ed4 ("Remove PriorityWeightStrategy reference in SDK"), SDK operators store weight_rule as a string instead of a PriorityWeightStrategy object. When TaskInstance.refresh_from_task() calls task.weight_rule.get_weight(), it fails silently due to contextlib.suppress(Exception), leaving priority_weight unset. Fix by wrapping SDK operators with create_scheduler_operator() before passing to TaskInstance, matching the pattern used in core tests.
Dev-iL
force-pushed
the
2512/fix_priority_weight
branch
from
dcd9918 to
08734bc
Compare
Member
|
Worth waiting for #59835 to be merged? |
Collaborator
Author
Collaborator
Author
|
Closing because unnecessary after #59835. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After commit 60b4ed4 ("Remove PriorityWeightStrategy reference in SDK"), SDK operators store weight_rule as a string instead of a PriorityWeightStrategy object. When TaskInstance.refresh_from_task() calls task.weight_rule.get_weight(), it fails silently due to contextlib.suppress(Exception), leaving priority_weight unset.
Fix by wrapping SDK operators with create_scheduler_operator() before passing to TaskInstance, matching the pattern used in core tests.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.