Conversation
The documentation would suggest that you can just use amqps:// uris with the nms.amqp provider, but sadly this doesn't work without a specific config file. Secure amqps should work, and should not need extra work.
davidvoit
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the amqps (AMQP over TLS) URI scheme to the NMS connection factory. The change maps the amqps scheme to the same Apache.NMS.AMQP provider used for the amqp scheme, enabling secure AMQP connections.
- Added
amqpsscheme mapping to the schema provider factory map
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Should I also add failover: uri support? If we only using "using Apache.NMS" this also doesn't work without nmsprovider-failover.xml config files. |
failover: uris are also used by the amqp nms provider
| new ProviderFactoryInfo("Apache.NMS.AMQP", "Apache.NMS.AMQP.ConnectionFactory"); | ||
| schemaProviderFactoryMap["amqps"] = | ||
| new ProviderFactoryInfo("Apache.NMS.AMQP", "Apache.NMS.AMQP.ConnectionFactory"); | ||
| schemaProviderFactoryMap["failover"] = |
There was a problem hiding this comment.
what if someone wants to use failover with open-wire?
There was a problem hiding this comment.
Wouldn't this be activemq:failover then? We could also implement a second level lookup if needed. look for tcp/ssl or amqp/amqps
There was a problem hiding this comment.
But failover: are currently so or so not working. I think it would be fine to conenect it to amqp and go with activemq:failover for openwire as the new default. What do you think, should we write some new uri parsind and decsision logick or would this new default be fine?
2 participants
The documentation would suggest that you can just use amqps:// uris with the nms.amqp provider, but sadly this doesn't work without a specific config file.
Secure amqps should work, and should not need extra work.