Accumulo Proxy build with Accumulo 2.1.3#84
Conversation
… Several methods were removed or renamed, and workarounds had to be found. However, the actual functionality of the Proxy has not been fully tested yet.
|
This updated version of the proxy does appear to successfully allow another program to connect to Accumulo! |
…nside of Proxy.java.
…hreadPoolExecutor.
|
Taking a look at this now. One thing to make sure of is that the versions (hadoop, zookeeper, etc.) match whats in 2.1.3. Comparing the poms, i see mismatches for the parent pom version, the hadoop version. Also, not super related is I think we can remove the surefire version listed in the accumulo-proxy pom as that is handled by the parent pom. Another place to double check for correct versions would be the dockerfile. Edit: Actually I think updating the dockerfile could be handled as a follow-on PR. |
… that arose from updating various dependencies.
|
How did you test this? |
|
I tested it by creating a web app in python that used a python library to communicate with an instance of Accumulo through the Proxy. I was able to fully test logging in as a user, reading the contents of a table, and adding mutations to the table. Accumulo was installed using Fluo Uno. Through this process, I had to wrestle with the deprecated python 3 library I forked significantly more than the proxy itself. |
|
I was able to update and test the Dockerfile. Since that pertains to updating everything to Accumulo 2.1.3 I'll add those changes to this PR. |
Updated versions and hashes of Hadoop, Zookeeper, and Accumulo to fit the versions used in Accumulo 2.1.3. Additionally, updated "ENV name value" to "ENV name=value" (since Docker said that the former was outdated). Tested proxy through docker, confirmed that it functions as normal
ddanielr
left a comment
ddanielr
left a comment
There was a problem hiding this comment.
Changes were tested locally and ITs are passing.
Minor suggestions added to the PR.
| // TODO - This was left blank, I'm not sure why it's here. For now, it will log the max | ||
| // memory |
There was a problem hiding this comment.
Looking at ConditionalWriterConfig, there is no variable to assign for maxMemory.
I'm not sure why that is in the proxy.thrift as I don't see a maxMemory value in accumulo at all.
This can probably be removed in a follow up PR that modifies the proxy.thrift code and regenerates the thrift generated java code.
| } | ||
|
|
||
| // TODO: This MetricsInfo is a stub Metrics Info to allow the timed processor to build. If Metrics | ||
| // are wanted or needed in a later version of the proxy, this can be updated. |
There was a problem hiding this comment.
Suggest creating an issue ticket for adding a metrics Info object.
|
I looked at the warnings being produced in the build. |
Co-authored-by: Daniel Roberts <ddanielr@gmail.com>
3 participants
Although it can build, whether the proxy itself works hasn't been fully tested.