fix: wire gallery timing URL params so playlist advances on override#113
Conversation
shaderDisplayDuration, fortuneDuration, screenshotCaptureDuration were read in gallery.js but never mapped in config.js paramMapping, so URL overrides were silently dropped and the gallery always fell back to the 42s default shuffle.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
🎬 PR Preview Deployed!Your changes are now available for testing: Preview URL: https://ap0ught.github.io/matrix/pr-113/ Test Links:The preview will be updated automatically when you push new commits. Preview deployed from commit f150576 |
There was a problem hiding this comment.
Pull request overview
This PR fixes gallery mode timing URL overrides by wiring shaderDisplayDuration, fortuneDuration, and screenshotCaptureDuration into js/config.js’s paramMapping, so GalleryManager can actually receive these values from URL params instead of always falling back to its internal defaults.
Changes:
- Added URL param mappings for gallery timing overrides (
shaderDisplayDuration,fortuneDuration,screenshotCaptureDuration). - Ensures
makeConfig()includes these parsed values in the resulting config object (when provided), enabling the gallery playlist to advance according to overrides.
Summary
shaderDisplayDuration,fortuneDuration, andscreenshotCaptureDurationwere declared ingallery.jsbut never mapped inconfig.jsparamMapping, so URL overrides were silently dropped and the gallery always fell back to the 42s default shuffle.Verification
?shaderDisplayDuration=5000now observed ~5s transitions with 13 advances across 60s and 0 page errorsFiles changed