Skip to content

core: fix SEGV in param_qcd due to underflow when num_subbands is 0 #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bwendling wants to merge 1 commit into from
Closed

core: fix SEGV in param_qcd due to underflow when num_subbands is 0 #267

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/core/codestream/ojph_params.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1411,6 +1411,10 @@ namespace ojph {
else
idx = resolution ? (resolution - 1) * 3 + subband : 0;
if (idx >= num_subbands) {
if (num_subbands == 0)
OJPH_ERROR(0x00050102, "QCD/QCC marker segment contains no "
"quantization step sizes");

OJPH_INFO(0x00050101, "Trying to access quantization step size for "
"subband %d when the QCD/QCC marker segment specifies "
"quantization step sizes for %d subbands only. To continue "
Expand Down Expand Up @@ -1468,6 +1472,10 @@ namespace ojph {
else
idx = resolution ? (resolution - 1) * 3 + subband : 0;
if (idx >= num_subbands) {
if (num_subbands == 0)
OJPH_ERROR(0x00050112, "QCD/QCC marker segment contains no "
"quantization step sizes");

OJPH_INFO(0x00050111, "Trying to access quantization step size for "
"subband %d when the QCD/QCC marker segment specifies "
"quantization step sizes for %d subbands only. To continue "
Expand Down
Loading