Skip to content

fix: surface missing reviewer harness#318

Open
Vaibhaav-Tiwari wants to merge 2 commits into
mainfrom
fix/issue-303-missing-harness
Open

fix: surface missing reviewer harness#318
Vaibhaav-Tiwari wants to merge 2 commits into
mainfrom
fix/issue-303-missing-harness

Conversation

@Vaibhaav-Tiwari

Copy link
Copy Markdown
Collaborator

Summary

  • map missing reviewer harness binaries to a typed 422 REVIEWER_BINARY_NOT_FOUND response with the original cause preserved
  • record failed review launches as failed review runs so the UI has a durable trace instead of an empty gap
  • allow retrying the same commit after a failed review run by excluding failed runs from the review-run uniqueness gate

Closes #303

Tests

  • cd backend && go test ./internal/review
  • cd backend && go test ./internal/httpd/controllers
  • cd backend && go test ./internal/storage/sqlite ./internal/storage/sqlite/store

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(frontend/review): a missing harness (worker or reviewer) fails silently/opaquely — no user-facing message, no install pre-flight

2 participants