fix(session): make worker branch namespace child-safe#309
fix(session): make worker branch namespace child-safe#309neversettle17-101 wants to merge 2 commits into
Conversation
|
@neversettle17-101 can you check this edge case : If two sessions in the same repo somehow end up with |
|
On the The ambiguous case requires all of these to exist in the same repo:
That is unlikely because existing sessions from before this fix may have The more realistic compatibility case is an old running session with So I would keep this PR simple and not add extra tie-break logic unless we see this ambiguity in real state or a reviewer wants the deterministic fallback explicitly. |
Fixes #308
Summary
ao/<session-id>toao/<session-id>/rootso sibling PR branches likeao/<session-id>/<topic>are valid Git refs./rootsession branch also owns sibling branches under the same namespace.Root Cause
AO created the session root branch as
ao/<session-id>while instructing agents to create additional PR branches asao/<session-id>/<topic>. Git cannot create both refs becauserefs/heads/ao/<session-id>blocksrefs/heads/ao/<session-id>/<topic>.Tests
GOCACHE=/private/tmp/ao-go-build-cache go test ./internal/session_managerGOCACHE=/private/tmp/ao-go-build-cache go test ./internal/observe/scmGOCACHE=/private/tmp/ao-go-build-cache go test ./internal/cli -run 'TestSpawn'