feat(frontend): move kill session control to topbar beside Open orchestrator#298
Merged
Conversation
…strator
Relocate the worker "Kill session" control out of the inspector's Summary
"Danger zone" section and into the app topbar actions row, as a small
danger-tinted icon button next to "Open orchestrator". It only renders for
active worker sessions and keeps the same arm-then-confirm flow and
POST /sessions/{id}/kill behavior.
Move the kill-button tests to ShellTopbar.test.tsx accordingly.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Moves the worker Kill session control out of the inspector's Summary Danger zone section and into the app topbar actions row, rendering it as a small danger-tinted icon button right beside Open orchestrator.
Why
The kill control was buried in the Summary tab. Placing it alongside the existing topbar action makes it reachable in one click from any inspector view, without scrolling the Summary panel.
Details
SessionInspector.tsx: removed theDanger zonesection andKillSessionButton.ShellTopbar.tsx: addedTopbarKillButton, rendered only for active worker sessions (sessionIsActive) next to "Open orchestrator". Keeps the same arm → confirm flow andPOST /sessions/{id}/killbehavior, with a compact icon-button resting state and inline Confirm/Cancel when armed.styles.css: topbar kill button / confirm / cancel / error styles, using the existing--redtoken.SessionInspector.test.tsxto newShellTopbar.test.tsx.Verification
pnpm exec vitest run— 138 passed (15 files)pnpm exec tsc --noEmit— clean🤖 Generated with Claude Code