fix(frontend): stop sidebar repeating the session id under the title#283
Open
AgentWrapper wants to merge 2 commits into
Open
fix(frontend): stop sidebar repeating the session id under the title#283AgentWrapper wants to merge 2 commits into
AgentWrapper wants to merge 2 commits into
Conversation
A worker session with no displayName/issueId gets its title from useWorkspaceQuery's fallback (`displayName ?? issueId ?? id`), which resolves to the session id. The sidebar then rendered the title line and an id subtitle unconditionally, so the same string printed twice (e.g. "reverbcode-2" over "reverbcode-2"). Render the id subtitle only when it differs from the title, so it stays a useful secondary handle for renamed/issue-backed workers and collapses to a single line otherwise. Fixes #282 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
Contributor
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #282
Summary
A worker session with no
displayName/issueIdgets its title fromuseWorkspaceQuery's fallback (session.displayName ?? session.issueId ?? session.id), which resolves to the session id. The sidebar then rendered the title line (Sidebar.tsx) and an id subtitle unconditionally, so the same string printed twice (e.g.reverbcode-2overreverbcode-2) — the default state for any plainly-spawned, un-renamed worker.This renders the id subtitle only when it differs from the title: it stays a useful secondary handle for renamed / issue-backed workers, and collapses to a single line otherwise.
Test
cd frontend && npm run typecheck— cleancd frontend && npx vitest run src/renderer/components/Sidebar.test.tsx— 5 passed, including two new regression tests:title === id(asserts the string renders once)🤖 Generated with Claude Code