Skip to content

feat: [performance improvement] Optimize schedule filtering with Set lookup #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anyulled wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: [performance improvement] Optimize schedule filtering with Set lookup #259

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion components/schedule/ScheduleContainer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@ export default function ScheduleContainer({ initialSchedule, year }: Readonly<Sc
return initialSchedule;
}

const filterSessions = (sessions: GridSession[]) => sessions.filter((s) => savedSessionIds.includes(s.id) || s.isServiceSession);
const savedIdsSet = new Set(savedSessionIds);
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Jun 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To prevent potential runtime crashes, it is safer to defensively verify that savedSessionIds is an array before passing it to new Set(). Since savedSessionIds is loaded from localStorage in ScheduleProvider without explicit validation that the parsed JSON is indeed an array, any corrupted or non-array value (such as an object {}) in localStorage would cause new Set(savedSessionIds) to throw a TypeError and crash the application.

Suggested change
const savedIdsSet = new Set(savedSessionIds);
const savedIdsSet = new Set(Array.isArray(savedSessionIds) ? savedSessionIds : []);

const filterSessions = (sessions: GridSession[]) => sessions.filter((s) => savedIdsSet.has(s.id) || s.isServiceSession);

return initialSchedule.map((day) => ({
...day,
Expand Down
Loading