Skip to content

⚡ Bolt: Optimize schedule filtering #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
anyulled wants to merge 1 commit into from
Closed

⚡ Bolt: Optimize schedule filtering #180

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion components/schedule/ScheduleContainer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,9 @@ export default function ScheduleContainer({ initialSchedule, year }: Readonly<Sc
return initialSchedule;
}

const filterSessions = (sessions: GridSession[]) => sessions.filter((s) => savedSessionIds.includes(s.id) || s.isServiceSession);
// Convert savedSessionIds to a Set to improve lookup performance from O(N) to O(1)
const savedIdsSet = new Set(savedSessionIds);
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While converting the array to a Set here successfully improves the filtering performance from O(N*M) to O(N+M), this conversion still occurs every time the useMemo for filteredSchedule is re-evaluated (e.g., when initialSchedule changes or when showSavedOnly is toggled).

For a more robust architectural improvement, consider storing savedSessionIds as a Set directly within the ScheduleContext. This would eliminate the need for local conversion and also optimize the isSaved check in the context, which currently uses Array.prototype.includes() (O(M) complexity). This would provide O(1) lookups throughout the application without repeated overhead.

const filterSessions = (sessions: GridSession[]) => sessions.filter((s) => savedIdsSet.has(s.id) || s.isServiceSession);

return initialSchedule.map((day) => ({
...day,
Expand Down
Loading