Skip to content

⚡ Bolt: Optimize schedule filtering to use Set for O(1) lookups #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
anyulled wants to merge 1 commit into from
Closed

⚡ Bolt: Optimize schedule filtering to use Set for O(1) lookups #171

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion components/schedule/ScheduleContainer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@ export default function ScheduleContainer({ initialSchedule, year }: Readonly<Sc
return initialSchedule;
}

const filterSessions = (sessions: GridSession[]) => sessions.filter((s) => savedSessionIds.includes(s.id) || s.isServiceSession);
const savedSessionSet = new Set(savedSessionIds);
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Apr 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While creating a Set inside the useMemo is a significant improvement over Array.includes(), the savedSessionSet is currently recreated every time the useMemo re-runs (e.g., if initialSchedule changes while showSavedOnly is true). For even better performance, especially if the number of saved sessions grows very large, consider memoizing the Set independently or providing it directly from the ScheduleContext.

const filterSessions = (sessions: GridSession[]) => sessions.filter((s) => savedSessionSet.has(s.id) || s.isServiceSession);

return initialSchedule.map((day) => ({
...day,
Expand Down
Loading