Repository navigation
chore(deps): allow redis 7-8; lock redis 8.1.0 with stable kombu 5.7.0 - #758
Merged
Merged
Conversation
#665) Supersedes Dependabot #665, which needed kombu 5.7.0rc1 and reverted the fastapi upper bound raised by #726. Claude-Session: https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4
Deploying simple-module-python with
|
| Latest commit: |
d11b27c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b4301e54.simple-module-python.pages.dev |
| Branch Preview URL: | https://fix-redis-8.simple-module-python.pages.dev |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This replaces Dependabot #665. That PR could only resolve kombu
5.7.0rc1(a pre-release), and it would have put fastapi back to<0.160, undoing #726.simple_module_hosting[redis]andsimple_module_background_tasksnow acceptredis>=5,<9(previously<7).uv.lockmoves to redis 8.1.0, kombu 5.7.0 (stable, released 2026-11-03,redis<9) and amqp 5.4.2. Nothing else in the lock changes.Verification
make lintpasses.PYTEST_WORKERS=8 make test-pyonce, with Redis tests skipped locally. One test failed:test_eager_publish_from_a_plain_session_is_deliveredtimed out after 15 s while the whole suite was running. It passed 3 times out of 3 on its own, andbackground_tasks+framework/hosting(1681 tests) passed twice with-n 8.Closes #665
https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4