Repository navigation
fix(ui,cli): theme border colour by default; package-update covers groups, extras and npm pins (#714, #715) - #717
Merged
Conversation
…oups, extras and npm pins (#714, #715) Claude-Session: https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4
npm pins stay when the Python core pin is held back; registry timeouts and bad JSON skip instead of aborting; core looked up by normalised name; border rule also covers ::backdrop and ::file-selector-button. Claude-Session: https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4
Deploying simple-module-python with
|
| Latest commit: |
e536cbf
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1bee06eb.simple-module-python.pages.dev |
| Branch Preview URL: | https://feat-b29-ui-border-pkg-updat.simple-module-python.pages.dev |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two smaller fixes from the scaffolded-app feedback: bare
borderutilities now use the theme's border colour, andsmpy package-updateupdates every framework pin, not only[project] dependencies.Closes #714
Closes #715
What changed
@simple-module-py/ui'sglobals.cssbase layer now setsborder-color: var(--color-border)on*, ::before, ::after, ::backdrop, ::file-selector-button, the same selector list as Tailwind's preflight. A bareborder/border-bused to draw incurrentColor, which already affectedTableRow,PaginationBarand the sharing table. Any explicitborder-*class still wins; useborder-currentfor the old look.smpy package-updatecovers dependency groups and extras (cli: smpy package-update skips dependency-groups and the client app's @simple-module-py/* pins #715). Every string entry in[dependency-groups]and[project.optional-dependencies]is rewritten too, including a workspace root that has only a dev group.{include-group = …}entries are left alone, and root[tool.uv.sources]are honoured in members.@simple-module-py/*pins. Root andclient_app/package.json(dependencies, dev, optional and peer) move in lockstep to the selectedsimple_module_coreversion, keeping^/~/exact style and never downgrading.--dry-runwrites nothing; JSON indentation and newline style are preserved. The summary says to runuv syncand/ornpm installwhere needed.package_update.pyis split intopackage_update_deps.py(TOML) andpackage_update_npm.py(npm) to stay under the 300-line cap. Docs and the shippedsimple-module-cliskill are updated.Verification
make lint✓ ·make test-js✓ ·make test-py✓ (6500 passed, 41 skipped)test_cli_package_update_groups.py); npm sections and locations, pin styles, skips, held-back core, registry timeout and bad JSON, hyphenated core name (test_cli_package_update_npm.py); compiled-stylesheet border colours, including explicit-class precedence (ui-border-color.test.ts).https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4