Repository navigation
Tech-debt batch 26: upload queue honours cancels during session lookup; releases finished files (#695) - #704
Merged
Merged
Conversation
… File objects (#695) A cancel during the resumable-session lookup removed the row but the upload then started anyway; the queue now re-checks after each lookup. Completed rows released their File objects only on dismiss, so every uploaded file stayed referenced; they are dropped when the row clears. Claude-Session: https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4
… cancelled (#695) Review follow-up: startOver awaited discardSession without re-checking for a cancel before starting the new upload. Claude-Session: https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4
Deploying simple-module-python with
|
| Latest commit: |
4827a5b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://12f15b76.simple-module-python.pages.dev |
| Branch Preview URL: | https://tech-debt-b26-upload-queue.simple-module-python.pages.dev |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tech-debt batch 26 (from the 2026-10-28 scan).
Closes #695
What changed
modules/file_storage/file_storage/pages/upload-queue.ts:findSession/maybePause). A cancel during that await removed the row, but the upload then started with no visible row, the remaining gap from file_storage: cancelling a queued upload still uploads it #588. The queue now re-checks after the lookup, aftermaybePauserecords a waiting session, and after start-over'sdiscardSession(found in review).File. Completed rows were cleared from the list but theirFilestayed in the queue's map for the hook's lifetime. Rows that settle as done now drop their file; failed and still-uploading rows keep theirs for retry.Verification
make lint✓ ·make test-js✓ ·make test-py✓ (6407 passed, 39 skipped)New Vitest regressions in
file_storage_upload_queue_lifecycle.test.tscover:They fail without the fix.
Code review: one finding (start-over), fixed.
No browser QA: the races are timing-dependent and are covered deterministically by the Vitest regressions above.
https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4